Skip to content

Bump inherited_resources requirement to ~> 2.0 #8477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tagliala
Copy link
Contributor

  • Increased the inherited_resources gem version requirement from ~> 1.7 to ~> 2.0.
  • Ensures compatibility with the latest version and potential new features or fixes.

- Increased the inherited_resources gem version requirement from ~> 1.7
  to ~> 2.0.
- Ensures compatibility with the latest version and potential new
  features or fixes.
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (f22e6ec) to head (812c2cf).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8477   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4069     4069           
=======================================
  Hits         4033     4033           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit 8669d01 into activeadmin:master Sep 15, 2024
24 checks passed
@tagliala tagliala deleted the chore/require-inherited-resources-2 branch September 15, 2024 17:06
@adamk9k
Copy link

adamk9k commented Jun 5, 2025

@javierjulio will this make it into the current 3.x releases or only into version 4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants