Skip to content

Backport Use attribute_types instead of columns_hash to determine type #8469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2024
Merged

Backport Use attribute_types instead of columns_hash to determine type #8469

merged 1 commit into from
Sep 4, 2024

Conversation

mgrunberg
Copy link
Contributor

Backport #8457

javierjulio
javierjulio approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mgrunberg mgrunberg force-pushed the backport-8457 branch 2 times, most recently from 9639913 to 59b1f6b Compare September 4, 2024 13:45
@til @mgrunberg
Use attribute_types instead of columns_hash to determine type
351880b 
Previously, virtual attributes of type boolean with value `nil` would
not be rendered as status tag. This also improves boolean detection in
rare cases when an `attribute` declaration overrides the type detected
in the database.
@mgrunberg mgrunberg enabled auto-merge (squash) September 4, 2024 14:04
@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3-0-stable@983cf3a). Learn more about missing BASE report.

Additional details and impacted files 
@@              Coverage Diff              @@
##             3-0-stable    #8469   +/-   ##
=============================================
  Coverage              ?   99.19%           
=============================================
  Files                 ?      194           
  Lines                 ?     4963           
  Branches              ?        0           
=============================================
  Hits                  ?     4923           
  Misses                ?       40           
  Partials              ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgrunberg mgrunberg merged commit 276b0d4 into 3-0-stable Sep 4, 2024
19 checks passed
@mgrunberg mgrunberg deleted the backport-8457 branch September 4, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierjulio javierjulio javierjulio approved these changes

Assignees
No one assigned
Labels
type enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgrunberg @javierjulio @til