Fix batch action with partial and no confirm doesn't submit the form on click #8442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f1eee7 to
e8f8d42
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8442 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 141 141
Lines 4064 4064
=======================================
Hits 4028 4028
Misses 36 36 ☔ View full report in Codecov by Sentry. |
javierjulio
approved these changes
Aug 23, 2024
e8f8d42 to
7f47d94
Compare
7f47d94 to
fea3696
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A batch action rendered with a partial is automatically being submitted when the batch action is clicked as a result of #8389. The form is being submitted automatically if there is no
confirmdataset attribute.The batch action feature test was incorrectly passing because it was not re-rendering the page unless
inputs["starred"]was present.Fixes #8440