Change missing cache directory error to warning #1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR changes the error handling behavior when cache directories don't exist during the cache save operation. Instead of throwing an error that would fail the workflow, the action now logs a warning and continues execution.
- Replaces error throwing with warning logging when cache directories are missing
- Adds early return to prevent further cache operations when directories don't exist
- Improves developer experience by avoiding unnecessary workflow failures
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
priya-kinthali
approved these changes
Aug 21, 2025
priyagupta108
approved these changes
Aug 21, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the cache lookup logic to log a warning instead of throwing an error when a cache folder path is not found on disk.
Previously: action failed with Error: Cache folder path ... doesn't exist.
Now: action logs a warning via core.warning() and continues execution.
Motivation: In many cases, missing cache simply means there are no dependencies to cache, which should not fail the workflow.
This improves developer experience by preventing unnecessary workflow failures while still surfacing useful diagnostic information.
Related issue:
#436