Skip to content

Conversation

joshmgross
Copy link
Contributor

Preparing to release v6.4.0 which will include node-fetch - #321

@joshmgross joshmgross requested a review from a team January 26, 2023 16:14
@github-actions
Copy link

Hello from actions/github-script! (ae926c4)

@joshmgross joshmgross merged commit 98814c5 into main Jan 26, 2023
@joshmgross joshmgross deleted the joshmgross/bump-package-version branch January 26, 2023 16:32
@maxkostow
Copy link

This should have been a breaking change for anyone that manually installed node-fetch

const fetch = require('node-fetch')

Will now throw an error

SyntaxError: Identifier 'fetch' has already been declared

@joshmgross
Copy link
Contributor Author

Sorry about that @maxkostow, I'll keep that in mind for future releases.

At this point users are likely depending on node-fetch that's provided by this action, so I don't think we can roll back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants