Skip to content

Make it clear that require is a custom wrapper #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2021
Merged

Make it clear that require is a custom wrapper #190

merged 1 commit into from
Sep 14, 2021

Conversation

patrick91
Copy link
Contributor

I didn't realise require was a custom wrapper so I changed the read me to make it more obvious, but I'm happy to change the wording if this is still not clear or if is badly worded

@patrick91
Make it clear that require is a custom wrapper
282dd6a 
Happy to change the wording 😊
@patrick91 patrick91 requested a review from a team September 14, 2021 11:40
joshmgross
joshmgross approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@joshmgross joshmgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joshmgross joshmgross merged commit 5d31eec into actions:main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@joshmgross joshmgross joshmgross approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrick91 @joshmgross