fix: character-death parsing when only being assisted #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
==========================================
+ Coverage 80.19% 80.30% +0.10%
==========================================
Files 22 22
Lines 3666 3686 +20
==========================================
+ Hits 2940 2960 +20
Misses 585 585
Partials 141 141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
TibiaCharactersCharacter.gofile, focusing on improving the handling of character death data and adding a new test case. Key changes include adding anomitemptytag to theLevelfield, improving string sanitization, and adding logic to handle deaths with assists more accurately. Additionally, a new test case has been added to validate these changes.Improvements to character death data handling:
src/TibiaCharactersCharacter.go: Addedomitemptytag to theLevelfield in theDeathsstruct to omit the field when it is zero.src/TibiaCharactersCharacter.go: Enhanced string sanitization by removing line breaks and extra spaces, and added logic to handle deaths with assists more accurately. [1] [2] [3] [4] [5] [6]src/TibiaCharactersCharacter.go: Added trimming of HTML tags, spaces, and dots in theTibiaDataParseKillerfunction to ensure cleaner data.New test case:
src/TibiaCharactersCharacter_test.go: AddedTestNumber14to validate the handling of character deaths, including cases with assists and killers.fix #203
fix #402
fix #448