fix: parsing of boosted creature that is fictitious #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
==========================================
+ Coverage 79.76% 79.80% +0.03%
==========================================
Files 22 22
Lines 3648 3654 +6
==========================================
+ Hits 2910 2916 +6
Misses 600 600
Partials 138 138 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the handling of boosted creatures in the
TibiaCreaturesOverviewmodule. The most important changes include adding a new regex for boosted creature races, updating the implementation to handle cases where the boosted creature is not in the creature list, and adding a new test case for fictitious boosted creatures.Enhancements to boosted creature handling:
src/TibiaCreaturesOverview.go: AddedBoostedCreatureRaceRegexto match boosted creature races from image URLs.src/TibiaCreaturesOverview.go: UpdatedTibiaCreaturesOverviewImplfunction to include a fallback mechanism for boosted creatures not present in the creature list, extracting the name and race using the new regex.Testing improvements:
src/TibiaCreaturesOverview_test.go: AddedTestOverviewBoostedFictitiousto ensure the fallback mechanism works correctly by testing with a fictitious boosted creature.fix #438