fix: revert ReverseStack deletion and verify linting (#6474) #6494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6494 +/- ##
============================================
- Coverage 75.11% 75.10% -0.01%
+ Complexity 5574 5571 -3
============================================
Files 687 686 -1
Lines 19318 19307 -11
Branches 3732 3732
============================================
- Hits 14510 14500 -10
Misses 4245 4245
+ Partials 563 562 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DenizAltunkapan
requested changes
Aug 21, 2025
There was a problem hiding this comment.
Very good! Now please resolve the format issues to fix the failing workflows @VickySource
|
Thanks for catching that! I’ll apply clang-format to the updated files
and push the fix so the workflows pass.
…On Thu, Aug 21, 2025 at 9:27 PM Deniz Altunkapan ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Very good! Now please resolve the format issues to fix the failing
workflows @VickySource <https://github.com/VickySource>
—
Reply to this email directly, view it on GitHub
<#6494 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BL5S2UTCNSWN4XE4ACLO7PT3OXT5BAVCNFSM6AAAAACEO34FQ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCNBRGMZDKMRSG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi @DenizAltunkapan, thanks for reviewing! |
|
@VickySource I accidentally missed this earlier, but why did you undo the deletion of the Recursion classes? It was correct to delete ReverseStackUsingRecursion and the according test class. Please delete them so we can merge afterwards ;) |
|
Done.
…On Fri, 22 Aug, 2025, 1:13 am Deniz Altunkapan, ***@***.***> wrote:
*DenizAltunkapan* left a comment (TheAlgorithms/Java#6494)
<#6494 (comment)>
@VickySource <https://github.com/VickySource> I accidentally missed this
earlier, but why did you undo the deletion of the RenRecursion classes? It
was correct to delete ReverseStackUsingRecursion and the according test
class. Please delete them so we can merge afterwards ;)
—
Reply to this email directly, view it on GitHub
<#6494 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BL5S2URTAIUCAC73LS42LST3OYOOVAVCNFSM6AAAAACEO34FQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMJRHA3DAOJXHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi @DenizAltunkapan, I have deleted both ReverseStackUsingRecursion.java and ReverseStackUsingRecursionTest.java as requested. The branch is now updated and ready for review. |
DenizAltunkapan
approved these changes
Aug 22, 2025
|
Awesome, thanks!
…On Fri, 22 Aug, 2025, 11:11 am Deniz Altunkapan, ***@***.***> wrote:
Merged #6494 <#6494> into
master.
—
Reply to this email directly, view it on GitHub
<#6494 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BL5S2USG2SFVUUKIHDE2PLD3O2USNAVCNFSM6AAAAACEO34FQ2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJZGI4DAMRWGA2TQMY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The ReverseStackUsingRecursion.java implementation and ReverseStackUsingRecursionTest.java were accidentally deleted.
This PR restores both files and ensures they meet the project's style and linting requirements.
Changed
Verified formatting and linting:
Ran mvn checkstyle:check → BUILD SUCCESS
Spotless plugin not configured in the project → performed manual verification.
Verification steps performed
Confirmed both files match the upstream versions (no logic change).
Checked compilation → successful.
Lint check passed with no issues.
Notes for Reviewers
Only file restoration and formatting verification, And code logic changes.
Safe to merge — should restore repository consistency without conflicts.