Skip to content

Added constexpr GRAVITY constant (9.80665) as per guidelines #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 19, 2025
Merged

Added constexpr GRAVITY constant (9.80665) as per guidelines #2982

merged 4 commits into from
Aug 19, 2025

Conversation

kaushalsawariya
Copy link
Contributor

@kaushalsawariya kaushalsawariya commented Aug 17, 2025 •
edited
Loading

Description of Change

Checklist

  • Added description of change
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: Introduced GRAVITY constant (9.80665 m/s²) for consistent use across physics algorithms.

realstealthninja
realstealthninja requested changes Aug 17, 2025
View reviewed changes
realstealthninja and others added 2 commits August 17, 2025 21:46
@realstealthninja
Merge branch 'master' into feature/add-gravity-constant
d28937c
@kaushalsawariya @realstealthninja
Update physics/ground_to_ground_projectile_motion.cpp
2502f61 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@realstealthninja
Copy link
Collaborator

Have you ensured whether the tests are still working?

@realstealthninja realstealthninja added testing approved Approved; waiting for merge labels Aug 18, 2025
realstealthninja
realstealthninja approved these changes Aug 19, 2025
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing! well done

@realstealthninja realstealthninja merged commit c39d84b into TheAlgorithms:master Aug 19, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

+1 more reviewer

@mindaugl mindaugl mindaugl approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved Approved; waiting for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaushalsawariya @realstealthninja @mindaugl