feat: Add memoized version of factorial #2964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation to Check if a number is Even or Odd using Bitwise Operator
Deleted the one file as there was 2 files in the commit
|
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
realstealthninja
requested changes
Aug 20, 2025
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
modified
|
Changes has been updated thanks |
git5v
commented
Aug 21, 2025
realstealthninja
requested changes
Aug 21, 2025
|
Shouldnt this be in math directory since factorial is mathematics, Also the file name is too long rename the file to factorial_memoized.cpp or any other alternative. |
added __uint128_t for handling fixed-width integer types
deleted the file from dp folder
git5v
commented
Aug 21, 2025
realstealthninja
requested changes
Aug 22, 2025
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
added cstdint header and switched to uint64 Thanks
realstealthninja
requested changes
Aug 22, 2025
realstealthninja
requested changes
Aug 22, 2025
realstealthninja
requested changes
Aug 22, 2025
realstealthninja
approved these changes
Aug 22, 2025
|
Tested and verified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added
factorial_memoization.cppto the math directory, implementing factorial calculation using recursion with memoization (top-down dynamic programming).file location for ref:
math/factorial_memoization.cpp