Skip to content

Fixed CI/CD coverage #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

StormLord07
Copy link

I managed to fix the CI/CD pipeline for coverage by switching to gcovr, so if this is not something you want to do, tell me i'll try to find a solution to lcov, but i've tried updating versions and many other things and it still fails because of line endings, like in this issue but then it requires more and more ignores, at some point it doesn't look like coverage, here is the resulting link coveralls,

the Lint is still failing, but it looks like its by design. so the changes would be applied only manually?

root and others added 2 commits August 18, 2025 23:41
made the action run on fix/CI_CD

typo fix

added lcov dependency

made lcov a separate action

added gcovr as alternative to the lcov that doesn't work well with macro

coverage errors ignoring

made full switch to gcovr

removed lcov and glaze that was from other pr

fix of wrong configuring of preset

possible fix

fix

made gcovr generate .info file

fix

made cmake use current binary dir

propper syntax for output file

tried fixing build folder inclusion

naming fix

switched to the new coverage
@prince-chrismc
Copy link
Collaborator

This use to work with no code changes. I suspect the problem is the gcc or llvm and lcov in the github runner are incompatible. In my testing they are different versions.

The output has been super consistent but its been a while since I've looked at this prince-chrismc@8c83693

Why did the cmake module being used not work, is has support for both tools?

@prince-chrismc
Copy link
Collaborator

Yes the lint needs to be applied manually, there's a cli in the error message. Automatically with githubs permission model is not sensible

@StormLord07
Copy link
Author

This use to work with no code changes. I suspect the problem is the gcc or llvm and lcov in the github runner are incompatible. In my testing they are different versions.

Hmm, If i knew the commit at which the CI started failing, I'll go look into it, maybe the answer is in there, a lot of things started failing when we at our project updated gcc maybe here is something alike.

Why did the cmake module being used not work, is has support for both tools?

I'll try it out, couldn't find the info on the gcovr, might have to research that bit, was pretty late when i was finishing things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants