feat(persistence): durable sandbox persistence (SandboxStore + shared lock)#988
Open
AlemTuzlak wants to merge 3 commits into
Open
feat(persistence): durable sandbox persistence (SandboxStore + shared lock)#988AlemTuzlak wants to merge 3 commits into
AlemTuzlak wants to merge 3 commits into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Changeset Version Preview18 package(s) bumped directly, 35 bumped as dependents. 🟥 Major bumps
🟨 Minor bumps
🟩 Patch bumps
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=test:sherif,test:knip,tes... |
❌ Failed | 9m 35s | View ↗ |
nx run-many --targets=build --exclude=examples/... |
✅ Succeeded | 1m 47s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-07-25 06:02:57 UTC
AlemTuzlak
force-pushed
the
feat/persistence-sandbox
branch
2 times, most recently
from
July 23, 2026 12:14
4b2e68a to
e1e51d0
Compare
@tanstack/ai
@tanstack/ai-acp
@tanstack/ai-angular
@tanstack/ai-anthropic
@tanstack/ai-bedrock
@tanstack/ai-claude-code
@tanstack/ai-client
@tanstack/ai-code-mode
@tanstack/ai-code-mode-skills
@tanstack/ai-codex
@tanstack/ai-devtools-core
@tanstack/ai-durable-stream
@tanstack/ai-elevenlabs
@tanstack/ai-event-client
@tanstack/ai-fal
@tanstack/ai-gemini
@tanstack/ai-grok
@tanstack/ai-grok-build
@tanstack/ai-groq
@tanstack/ai-isolate-cloudflare
@tanstack/ai-isolate-node
@tanstack/ai-isolate-quickjs
@tanstack/ai-mcp
@tanstack/ai-memory
@tanstack/ai-mistral
@tanstack/ai-ollama
@tanstack/ai-openai
@tanstack/ai-opencode
@tanstack/ai-openrouter
@tanstack/ai-persistence
@tanstack/ai-persistence-cloudflare
@tanstack/ai-persistence-drizzle
@tanstack/ai-persistence-prisma
@tanstack/ai-preact
@tanstack/ai-react
@tanstack/ai-react-ui
@tanstack/ai-sandbox
@tanstack/ai-sandbox-cloudflare
@tanstack/ai-sandbox-daytona
@tanstack/ai-sandbox-docker
@tanstack/ai-sandbox-local-process
@tanstack/ai-sandbox-sprites
@tanstack/ai-sandbox-vercel
@tanstack/ai-solid
@tanstack/ai-solid-ui
@tanstack/ai-svelte
@tanstack/ai-utils
@tanstack/ai-vue
@tanstack/ai-vue-ui
@tanstack/openai-base
@tanstack/preact-ai-devtools
@tanstack/react-ai-devtools
@tanstack/solid-ai-devtools
commit: |
AlemTuzlak
force-pushed
the
feat/persistence-sandbox
branch
from
July 23, 2026 12:53
e1e51d0 to
ef3e5f5
Compare
tombeckenham
force-pushed
the
feat/persistence-core
branch
from
July 24, 2026 01:31
0b17612 to
d2d08e8
Compare
tombeckenham
force-pushed
the
feat/persistence-sandbox
branch
from
July 25, 2026 05:46
ef3e5f5 to
f4c053c
Compare
Contributor
|
Rebased onto latest Adapted to the post-schema-first core design rather than a raw cherry-pick of the pre-refactor commit:
Local green: typecheck + |
Sandbox resume (SandboxStore + shared lock) is provided by withPersistence and consumed by withSandbox. SandboxStore/SandboxStoreCapability and the lock primitives live in core @tanstack/ai; the persistence backends carry a durable sandbox store; conformance testkit, e2e, docs, and the ai-sandbox skill updated.
Rebase of durable sandbox persistence onto the post-schema-first feat/persistence-core layout: - Shared LocksCapability + SandboxStoreCapability live in core @tanstack/ai - Locks stay on withLocks (not the state bag); optional stores.sandbox is provided by withPersistence when present - createDrizzleSandboxStore(db, table) / createPrismaSandboxStore / createD1SandboxStore; sqlite convenience factory includes sandbox store - Sandboxes stay outside the chat BYO schema contract - Update docs, e2e harness, and conformance tests for the new wiring
tombeckenham
force-pushed
the
feat/persistence-sandbox
branch
from
July 25, 2026 05:49
24360f7 to
687f800
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #984. Lands the sandbox persistence piece #984 explicitly deferred: durable, multi-instance-correct resume for
@tanstack/ai-sandbox.withSandboxalready consumesSandboxStore(which sandbox to resume) andLockStore(mutual exclusion around ensure) as optional capabilities, defaulting to in-memory (single-process). This adds the durable half — no behavioral change to the sandbox layer.Core: one shared
lockstokenThe
'locks'capability now lives in core@tanstack/ai(LocksCapability,LockStore,InMemoryLockStore,getLocks,provideLocks);@tanstack/ai-sandboxand@tanstack/ai-persistencere-export it. Because capability identity is by reference, one shared token means awithPersistence({ stores: { locks } })already in the chain feeds the sandbox lock automatically — this is the "sandbox-consumer bridge" #984 noted as deferred.@tanstack/ai-sandboxwithSandboxPersistence({ store, locks? })— provides a durableSandboxStore(and optional distributed lock) towithSandbox. Compose beforewithSandbox.SandboxStoreconformance testkit exported at@tanstack/ai-sandbox/testkit(runSandboxStoreConformance).Durable
SandboxStorebackends@tanstack/ai-persistence-drizzle—createDrizzleSandboxStore(db)+ a newsandboxestable folded into the initial migration (regenerated; asset synced to the Cloudflare sibling).@tanstack/ai-persistence-prisma—createPrismaSandboxStore(prisma)+ aSandboxmodel in the fragment.@tanstack/ai-persistence-cloudflare—createD1SandboxStore(d1)(delegates to Drizzle); the existing Durable-Object lock doubles as the distributed sandbox lock.The three backends add
@tanstack/ai-sandboxas an optional peer dependency. Sandboxes stays out of the chat BYO schema/model contract, so chat-only users are unaffected.Tests / docs / skill
withSandboxPersistenceprovide + cross-run-resume unit tests.docs/sandbox/persistence.md(+ nav, overview callout, cross-links from the persistence backend docs).ai-sandboxagent skill./api/sandbox-durabilityharness route + spec asserting a second run resumes the persisted sandbox (create stays 1).Testing
Green locally (canonical nx targets,
--skip-nx-cache):test:sherif,test:knip,test:docs,test:kiira,test:oxlint,test:types, andtest:libfor@tanstack/ai,@tanstack/ai-sandbox, and all four persistence packages (conformance + wiring).@tanstack/ai-sandboxbuilds clean including the testkit + DTS.Deferred to CI (per #984's precedent — this dev machine's nx output-materialization is unreliable here, which also blocks the Playwright dev server for every route): the full workspace
build/test:buildand the Playwrighttest:e2erun. The sandbox-durability spec is authored, registered in the route tree, and typechecks; the identical server-side-resume behavior is covered by the@tanstack/ai-sandboxpersistence.test.tsunit test.Release
Changeset: minor for
@tanstack/ai,@tanstack/ai-sandbox, and the four persistence packages.