Skip to content

[dotnet][rb][java][js][py] Automated Browser Version Update #16235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

[dotnet][rb][java][js][py] Automated Browser Version Update #16235

merged 1 commit into from
Aug 22, 2025

Conversation

selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Aug 22, 2025 •
edited by qodo-merge-pro bot
Loading

User description

This is an automated pull request to update pinned browsers and drivers

Merge after verify the new browser versions properly passing the tests and no bugs need to be filed

PR Type

Other

Description

  • Update Microsoft Edge browser version from 139.0.3405.102 to 139.0.3405.111

  • Update SHA256 checksums for both macOS and Linux Edge packages

  • Update package file paths to reflect new version numbers

Diagram Walkthrough

flowchart LR
  A["Edge 139.0.3405.102"] --> B["Edge 139.0.3405.111"]
  B --> C["Updated SHA256 checksums"]
  B --> D["Updated package paths"]
Loading

File Walkthrough
Relevant files
Dependencies
repositories.bzl
Update Edge browser version and checksums                               

common/repositories.bzl

  • Update Microsoft Edge version from 139.0.3405.102 to 139.0.3405.111
  • Update SHA256 checksums for macOS and Linux Edge packages
  • Update package file paths to match new version numbers
 +5/-5     

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Aug 22, 2025
@qodo-merge-pro Qodo Merge Pro
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 Security concerns

Supply chain:
External binary URLs and checksums were updated. Ensure checksums are independently verified and downloads occur over HTTPS with pinning where possible.

⚡ Recommended focus areas for review

Integrity Check

Verify that the new SHA256 values match the downloaded artifacts for both macOS and Linux Edge packages to prevent cache or supply-chain issues.

 
        url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/017e25fc-2906-45b2-958c-1c71c4667dc1/MicrosoftEdge-139.0.3405.111.pkg",
        sha256 = "1aa42cbaaf38b035e17d43fbbe0a293ceb286c5fd298d463b1a369ed900a03ac",
        move = {
            "MicrosoftEdge-139.0.3405.111.pkg/Payload/Microsoft Edge.app": "Edge.app",
        },
        build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])

exports_files(["Edge.app"])

js_library(
    name = "edge-js",
    data = glob(["Edge.app/**/*"]),
)
""",
    )

    deb_archive(
        name = "linux_edge",
        url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_139.0.3405.111-1_amd64.deb",
        sha256 = "d61b2fcef695083496184a6a323b2bcfb57d45af8fb6867ffe54974a5992dc52",
Path Consistency

Confirm that the updated macOS package internal path matches the move mapping so that Edge.app is correctly extracted and referenced by downstream rules.

 
move = {
    "MicrosoftEdge-139.0.3405.111.pkg/Payload/Microsoft Edge.app": "Edge.app",
},
build_file_content = """

@qodo-merge-pro Qodo Merge Pro
Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Fix macOS pkg move path

The move path includes the outer .pkg name, which is not present in the
extracted archive structure and will cause Bazel to fail moving files. Update
the path to point to the app within the extracted payload root. Verify the
internal layout with pkgutil --expand if unsure.

common/repositories.bzl [124-132]

 pkg_archive(
     name = "mac_edge",
     url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/017e25fc-2906-45b2-958c-1c71c4667dc1/MicrosoftEdge-139.0.3405.111.pkg",
     sha256 = "1aa42cbaaf38b035e17d43fbbe0a293ceb286c5fd298d463b1a369ed900a03ac",
     move = {
-        "MicrosoftEdge-139.0.3405.111.pkg/Payload/Microsoft Edge.app": "Edge.app",
+        "Payload/Microsoft Edge.app": "Edge.app",
     },
     build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
  • Apply / Chat
Suggestion importance[1-10]: 9

__

Why: This suggestion correctly identifies a likely bug in the move path for the pkg_archive rule, which would cause the build to fail.

High
  • More

@navin772 navin772 merged commit 12bf38f into trunk Aug 22, 2025
36 checks passed
@navin772 navin772 deleted the pinned-browser-updates branch August 22, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
B-build Includes scripting, bazel and CI integrations Possible security concern Review effort 2/5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@selenium-ci @navin772