-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[dotnet] [bidi] Remove IEnumerable of command results #16219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
User description
This contributes to #16095
💥 What does this PR do?
Remove syntax sugar and be more straightforward. Simplifying things as much possible. Any other sugar can be treated as "alternative API" via extensions.
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement
Description
Remove IEnumerable implementation from BiDi command results
Simplify result classes to use primary constructors
Delete custom JSON converters for enumerable results
Update test code to access properties directly
Diagram Walkthrough
File Walkthrough
14 files
Simplify GetClientWindowsResult to primary constructor
Simplify GetUserContextsResult to primary constructor
Update GetRealms call to access Realms property
Simplify GetTreeResult to primary constructor
Simplify LocateNodesResult to primary constructor
Remove enumerable JSON converter registrations
Delete GetClientWindowsResult JSON converter
Delete GetCookiesResult JSON converter
Delete GetRealmsResult JSON converter
Delete GetTreeResult JSON converter
Delete GetUserContextsResult JSON converter
Delete LocateNodesResult JSON converter
Simplify GetRealmsResult to primary constructor
Simplify GetCookiesResult to primary constructor
8 files
Update test to access Contexts property
Update tests to access result properties
Update tests to access Contexts property
Update test to access Nodes property
Update test to access Realms property
Update test to access Realms property
Update tests to access Realms property
Update tests to access Cookies property