-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[grid] Replace Guava list,set,map and sorted set with Java equivalent #16206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
java/src/org/openqa/selenium/grid/commands/EventBusCommand.java
Outdated
Show resolved
Hide resolved
Found an issue in a related PR. Trying to sort it out first, then accordingly update here if required. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
User description
🔗 Related Issues
Starting PR for replacing Guava's Immutable Set, List, Map, SortSet and Primitives usage with Java 11 or other equivalent in the Grid.
💥 What does this PR do?
PR replaces Guava's Immutable Set, List, Map, SortSet and Primitives usage with Java 11 or other equivalent in the Grid's packages, commands and config. The rest of the change will be done as follow up PRs.
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement
Description
Replace Guava collections with Java 11 equivalents
Remove dependencies on ImmutableList, ImmutableSet, ImmutableMap
Update sorted collections to use TreeSet
Modernize collection creation patterns
Diagram Walkthrough
File Walkthrough
14 files
Replace ImmutableMap with Map.of
Replace ImmutableMap with Map.of
Replace ImmutableSet and ImmutableMap with Java equivalents
Replace ImmutableSet with Set.of
Replace ImmutableSet with Set.of
Replace Guava collections with TreeSet and List.copyOf
Replace Guava collectors with Java stream collectors
Replace ImmutableMap and ImmutableSortedSet with Java equivalents
Replace ImmutableList with List.copyOf
Replace ImmutableSet and ImmutableSortedSet with Java equivalents
Replace Guava Primitives and collections with Java equivalents
Replace ImmutableList and ImmutableSortedSet with Java equivalents
Replace Guava collections with Java unmodifiable collections
Replace ImmutableList and ImmutableSortedSet with Java equivalents