Skip to content

Remove completed TODO #6095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

Remove completed TODO #6095

merged 1 commit into from
Aug 20, 2025

Conversation

moreal
Copy link
Contributor

@moreal moreal commented Aug 15, 2025 •
edited by coderabbitai bot
Loading

I'm not sure about the context when the TODO comment was written, but according to the comment, these lines can be removed because cargo run -- Lib/test/test_fstring.py runs successfully.

Summary by CodeRabbit

  • Tests
    • Streamlined complex formatting scenario tests into a simpler, representative case to improve readability and reduce fragility.
    • Preserved coverage to ensure invalid formatting specifications still raise appropriate errors.
    • Improved stability and maintainability of the test suite; potential reduction in false positives/negatives.
    • No changes to application behavior or features; end users should see no impact.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 15, 2025 •
edited
Loading

Walkthrough

Test-only changes: removed complex f-string format-spec tests and added a simpler test using part_spec = ">+#10x" to format 16. Retained an assertion that an invalid spec ("bla") raises ValueError. No production code changes.

Changes

Cohort / File(s) Summary
F-string syntax tests
extra_tests/snippets/syntax_fstring.py		 Removed intricate inline-constructed hex format-spec tests; added a concise test with part_spec=">+#10x" formatting 16; kept invalid spec ValueError check.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I nibbled old specs with a hop and a spin,
Trimmed tangled strings, let the simple one win.
A hex of sixteen, padded just right—
Plus sign and 0x gleam in the night.
If “bla” sneaks in? I thump with care—
ValueError caught, all tests fair! 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a9a9e3b and e66c505.

📒 Files selected for processing (1)
  • extra_tests/snippets/syntax_fstring.py (0 hunks)
💤 Files with no reviewable changes (1)
  • extra_tests/snippets/syntax_fstring.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Run snippets and cpython tests (windows-latest)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@moreal moreal marked this pull request as ready for review August 15, 2025 01:47
youknowone
youknowone approved these changes Aug 20, 2025
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone youknowone merged commit 44a8c9f into RustPython:main Aug 20, 2025
12 checks passed
ever0de pushed a commit to ever0de/RustPython that referenced this pull request Aug 20, 2025
@moreal @ever0de
Remove completed TODO of extra_tests/fstring.py (RustPython#6095)
adf3752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moreal @youknowone