Correctly implement isolation_level setter to handle deletion
#5983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
""" WalkthroughThe setter method for the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant Connection
participant VM
Caller->>Connection: set_isolation_level(value: PySetterValue, vm)
alt value is Assignment
Connection->>Connection: Convert value to Option<PyStrRef>
alt Value is Some
Connection->>Connection: Validate isolation level string
end
Connection->>Connection: Swap internal isolation level
alt New value is None and not autocommit
Connection->>Connection: Commit pending transaction
end
else value is Deletion
Connection->>VM: Raise AttributeError ("cannot delete attribute")
end
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
youknowone
reviewed
Jul 17, 2025
stdlib/src/sqlite.rs
Outdated
| if let Some(val) = &val { | ||
| begin_statement_ptr_from_isolation_level(val, vm)?; | ||
| } | ||
| fn set_isolation_level(&self, value: PySetterValue, vm: &VirtualMachine) -> PyResult<()> { |
There was a problem hiding this comment.
Suggested change
| fn set_isolation_level(&self, value: PySetterValue, vm: &VirtualMachine) -> PyResult<()> { | |
| fn set_isolation_level(&self, value: PySetterValue<Option<PyStrRef>>, vm: &VirtualMachine) -> PyResult<()> { |
How about trying this?
youknowone
approved these changes
Jul 18, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref
I noticed CPython's error message is just "cannot delete attribute". I made mine more informative (...'isolation_level' attribute...). Should I change it to match CPython for exact compatibility?
Summary by CodeRabbit
Bug Fixes
New Features
None.