[bsp/gd32] add gd32h759i-eval bsp add fix drv_usart.c #10623

Yaochenger · 2025-08-20T10:01:04Z

拉取/合并请求描述：(PR description)

[
并确认并列出已经在什么情况或板卡上进行了测试。
And confirm in which case or board has been tested. -->

为什么提交这份PR (why to submit this PR)

add gd32h759i-eval bsp
fix drv_usart.c

请提供验证的bsp和config (provide the config and bsp)

bsp/gd/arm/gd32h759i-eval
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

supperthomas · 2025-08-21T01:43:06Z

如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

github-actions · 2025-08-21T09:38:05Z

📌 Code Review Assignment

🏷️ Tag: workflow

Reviewers: Rbb666 kurisaW supperthomas

Changed Files (Click to expand)

.github/ALL_BSP_COMPILE.json

📊 Current Review Status (Last Updated: 2025-08-22 10:18 CST)

⌛ Rbb666 Pending Review
⌛ kurisaW Pending Review
⌛ supperthomas Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

This PR adds support for the GD32H759I-EVAL board and introduces DMA functionality for UART in the GD32 BSP. The changes include adding a new board configuration, enabling DMA support for UART operations, and fixing issues in the UART driver implementation.

Adds new BSP for GD32H759I-EVAL board with complete project configuration
Implements comprehensive DMA support for UART transmission and reception
Fixes pin configurations and conditional compilation issues in the UART driver

Reviewed Changes

Copilot reviewed 33 out of 35 changed files in this pull request and generated 3 comments.

File	Description
`bsp/gd32/arm/libraries/gd32_drivers/drv_usart.h`	Adds DMA structure definitions and conditionally disables DMA for non-H7 series
`bsp/gd32/arm/libraries/gd32_drivers/drv_usart.c`	Major refactor adding DMA support, interrupt handlers, and GPIO configuration fixes
`bsp/gd32/arm/gd32h759i-start/rtconfig.h`	Disables DMA configuration for start board
`bsp/gd32/arm/gd32h759i-eval/*`	Complete new BSP with project files and configuration

Comments suppressed due to low confidence (1)

bsp/gd32/arm/libraries/gd32_drivers/drv_usart.c:415

[bug] Inconsistent GPIO pin configuration for UART0 / UART0的GPIO引脚配置不一致。 English: The removed lines 411-415 showed conflicting pin configurations for UART0 on GD32H7xx. The code originally had separate configurations for H7xx (GPIOF pins 4,5) but now defaults to GPIOA pins 9,10. Verify this is correct for the H7xx series. / 中文：删除的第411-415行显示了GD32H7xx上UART0的引脚配置冲突。代码原本对H7xx有单独配置（GPIOF引脚4,5），但现在默认为GPIOA引脚9,10。请验证这对H7xx系列是否正确。

#if defined SOC_SERIES_GD32F4xx || defined SOC_SERIES_GD32F5xx || defined SOC_SERIES_GD32H7xx
        RCU_GPIOA, RCU_GPIOA,                  /* tx gpio clock, rx gpio clock */
        GPIOA, GPIO_AF_7, GPIO_PIN_9,          /* tx port, tx alternate, tx pin */
        GPIOA, GPIO_AF_7, GPIO_PIN_10,         /* rx port, rx alternate, rx pin */
#elif defined SOC_SERIES_GD32E50x
        RCU_GPIOA, RCU_GPIOA,                  /* tx gpio clock, rx gpio clock */
        GPIOA, 0, GPIO_PIN_9,                  /* tx port, tx alternate, tx pin */
        GPIOA, 0, GPIO_PIN_10,                 /* rx port, rx alternate, rx pin */

Copilot · 2025-08-21T12:31:13Z

bsp/gd32/arm/libraries/gd32_drivers/drv_usart.c

-        GPIOA, GPIO_PIN_3,                      /* rx port, rx pin */
+        RCU_GPIOA, RCU_GPIOA,                   // periph clock, tx gpio clock, rt gpio clock
+        GPIOA, GPIO_PIN_2,                      // tx port, tx pin
+        GPIOA, GPIO_PIN_3,                      // rx port, rx pin


[nitpick] [best_practices] Inconsistent comment style / 注释风格不一致。 English: The code mixes C-style (/* /) and C++-style (//) comments. For consistency with RT-Thread coding standards, use C-style comments throughout. / 中文：代码混合使用C风格（/ */）和C++风格（//）注释。为了与RT-Thread编码标准保持一致，应全程使用C风格注释。

Suggested change

GPIOA, GPIO_PIN_3, // rx port, rx pin

RCU_GPIOA, RCU_GPIOA, /* periph clock, tx gpio clock, rt gpio clock */

GPIOA, GPIO_PIN_2, /* tx port, tx pin */

GPIOA, GPIO_PIN_3, /* rx port, rx pin */

Copilot · 2025-08-21T12:31:14Z

bsp/gd32/arm/libraries/gd32_drivers/drv_usart.c

+    dma_deinit(uart->uart_tx_dma->dma_periph, uart->uart_tx_dma->dma_ch);
+
+    dma_single_data_para_struct_init(&dma_init_struct);
+    dma_init_struct.request      = uart->uart_tx_dma->dma_mux_req_rx;


[bug] Incorrect DMA request assignment for TX / TX的DMA请求分配错误。 English: For TX DMA configuration, the code uses dma_mux_req_rx field, which appears to be for RX operations based on the field name. This should likely use a TX-specific request field. / 中文：在TX DMA配置中，代码使用了dma_mux_req_rx字段，从字段名来看这似乎是用于RX操作的。这应该使用TX特定的请求字段。

Suggested change

dma_init_struct.request = uart->uart_tx_dma->dma_mux_req_rx;

dma_init_struct.request = uart->uart_tx_dma->dma_mux_req_tx;

Copilot · 2025-08-21T12:31:14Z

bsp/gd32/arm/libraries/gd32_drivers/drv_usart.c

@@ -558,13 +1150,29 @@ static void GD32_UART_IRQHandler(struct rt_serial_device *serial)
    RT_ASSERT(uart != RT_NULL);

    /* UART in mode Receiver -------------------------------------------------*/
-    if ((usart_interrupt_flag_get(uart->uart_periph, USART_INT_FLAG_RBNE) != RESET) &&
-            (usart_flag_get(uart->uart_periph, USART_FLAG_RBNE) != RESET))
+    if ((usart_interrupt_flag_get(uart->uart_periph, USART_INT_FLAG_RBNE) != RESET))


[bug] Removed USART_FLAG_RBNE check may cause issues / 移除USART_FLAG_RBNE检查可能导致问题。 English: The original code checked both USART_INT_FLAG_RBNE and USART_FLAG_RBNE, but the new code only checks the interrupt flag. This might cause the ISR to trigger even when no data is actually available, leading to potential race conditions. / 中文：原始代码同时检查USART_INT_FLAG_RBNE和USART_FLAG_RBNE，但新代码只检查中断标志。这可能导致即使没有数据可用时ISR也会触发，从而导致潜在的竞争条件。

Suggested change

if ((usart_interrupt_flag_get(uart->uart_periph, USART_INT_FLAG_RBNE) != RESET))

if ((usart_interrupt_flag_get(uart->uart_periph, USART_INT_FLAG_RBNE) != RESET) &&

(usart_flag_get(uart->uart_periph, USART_FLAG_RBNE) != RESET))

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions bot added BSP BSP: GD32 BSP related with GD32 labels Aug 20, 2025

[bsp/gd32] add gd32h759i-eval bsp

e6a17d7

Yaochenger force-pushed the GD32H7 branch from 07e92f0 to e6a17d7 Compare August 20, 2025 10:11

Rbb666 requested a review from Copilot August 20, 2025 10:27

This comment was marked as outdated.

Sign in to view

[fix] Update gd32h759i-start config

a00c5e8

supperthomas added the BSP: new bsp board New added bsp, need sync action label Aug 21, 2025

添加BSP CI看护

7bfed76

Yaochenger requested a review from supperthomas as a code owner August 21, 2025 09:37

github-actions bot added the action github action yml imporve label Aug 21, 2025

Yaochenger closed this Aug 21, 2025

Yaochenger reopened this Aug 21, 2025

Rbb666 closed this Aug 21, 2025

Rbb666 reopened this Aug 21, 2025

BernardXiong requested a review from Copilot August 21, 2025 10:51

This comment was marked as outdated.

Sign in to view

Apply suggestions from code review

db84430

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

BernardXiong requested a review from Copilot August 21, 2025 12:28

Copilot AI reviewed Aug 21, 2025

View reviewed changes

Yaochenger and others added 2 commits August 22, 2025 10:04

Update bsp/gd32/arm/libraries/gd32_drivers/drv_usart.c

ce93b89

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update bsp/gd32/arm/libraries/gd32_drivers/drv_usart.c

5b4577b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Yaochenger force-pushed the GD32H7 branch from dbf0761 to 5b4577b Compare August 22, 2025 02:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[bsp/gd32] add gd32h759i-eval bsp add fix drv_usart.c #10623

[bsp/gd32] add gd32h759i-eval bsp add fix drv_usart.c #10623

Yaochenger commented Aug 20, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

supperthomas commented Aug 21, 2025

Uh oh!

github-actions bot commented Aug 21, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Uh oh!

	dma_init_struct.request = uart->uart_tx_dma->dma_mux_req_rx;
	dma_init_struct.request = uart->uart_tx_dma->dma_mux_req_tx;

	if ((usart_interrupt_flag_get(uart->uart_periph, USART_INT_FLAG_RBNE) != RESET))
	if ((usart_interrupt_flag_get(uart->uart_periph, USART_INT_FLAG_RBNE) != RESET) &&
	(usart_flag_get(uart->uart_periph, USART_FLAG_RBNE) != RESET))

[bsp/gd32] add gd32h759i-eval bsp add fix drv_usart.c #10623

Are you sure you want to change the base?

[bsp/gd32] add gd32h759i-eval bsp add fix drv_usart.c #10623

Conversation

Yaochenger commented Aug 20, 2025

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

This comment was marked as outdated.

Uh oh!

supperthomas commented Aug 21, 2025

Uh oh!

github-actions bot commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: workflow

📊 Current Review Status (Last Updated: 2025-08-22 10:18 CST)

📝 Review Instructions

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 21, 2025 •

edited

Loading