bsp: k230: increase object name max length to 16 #10612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📌 Code Review Assignment🏷️ Tag: bsp_k230Reviewers: unicornx Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-08-18 15:03 CST)
📝 Review Instructions
|
Rbb666
approved these changes
Aug 18, 2025
Fixes: 62f3fb4: fix(kernel)/improve(utest):fix the legacy issue related to the length of the object name version RT-Thread#10537 After this patch, if length of object name exceeds (RT_NAME_MAX - 1), RTT will assert and oops when runing, but not in period of building. Though I don't think it's a good solution, but don't want to argue more about this. Old RT_NAME_MAX is 8 for k230, and some object names, such as "hwtimer0", which name length is 8, breaking the new rule. Just update configuration of k230 bsp and increase RT_NAME_MAX from 8 to 16, which should be long enough for k230. Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
7df6ef5 to
f9f2717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: 62f3fb4: fix(kernel)/improve(utest):fix the legacy issue related to the length of the object name version #10537
补丁生效后，如果对象名称长度超过 (RT_NAME_MAX - 1)，RTT 会在运行时断言并抛出错误如下，但在构建期间不会检查这个错误。
旧的 k230 的
RT_NAME_MAX长度为 8，而某些对象名称（例如“hwtimer0”）的名称长度为 8，违反了新规则。更新 k230 bsp 的配置，将
RT_NAME_MAX从8 增加到 16，这对于 k230 来说应该足够长了。小问题：运行
scons --menuconfig后只修改了RT_NAME_MAX但保存后发现改了很多处地方，但都是一些 注释的，感觉应该不会有影响。