-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Add Runtime search property #24992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TravisEz13
wants to merge
4
commits into
PowerShell:master
Choose a base branch
from
TravisEz13:addRuntimeSearchProp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Runtime search property #24992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI |
Azure Pipelines successfully started running 2 pipeline(s). |
daxian-dbw
reviewed
Feb 28, 2025
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
TravisEz13
commented
Mar 11, 2025
12 tasks
PR: #25837 Fixed this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request includes changes to the build configuration and deployment properties in the
PowerShell.Common.props
andbuild.psm1
files. The main goal is to refine the build and deployment process for different types of deployments.Build and Deployment Configuration Improvements:
PowerShell.Common.props
: Added new property groups to handle different deployment types, specifically for Framework dependent deployments (FddPackage
) and tools (FddTool
). This includes setting theAppHostDotNetSearch
property and handling thePublishReadyToRun
property appropriately based on the deployment type.build.psm1
: Updated the build script to pass theAppDeployment
property, allowing thePowerShell.Common.props
file to set the correct properties for different deployment types. This includes changes to handleFddTool
andFddPackage
deployments. [1] [2]PR Context
This property is only for Mariner currently.
.NET tools are expected to respect
DOTNET_ROOT
. However, the package for Mariner should not useDOTNET_ROOT
, but use a system defined dotnet runtime instead.Self-Contained Deployments (SCD) installs don't support this new property.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).