Skip to content

Add Runtime search property #24992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Feb 11, 2025

PR Summary

This pull request includes changes to the build configuration and deployment properties in the PowerShell.Common.props and build.psm1 files. The main goal is to refine the build and deployment process for different types of deployments.

Build and Deployment Configuration Improvements:

  • PowerShell.Common.props: Added new property groups to handle different deployment types, specifically for Framework dependent deployments (FddPackage) and tools (FddTool). This includes setting the AppHostDotNetSearch property and handling the PublishReadyToRun property appropriately based on the deployment type.

  • build.psm1: Updated the build script to pass the AppDeployment property, allowing the PowerShell.Common.props file to set the correct properties for different deployment types. This includes changes to handle FddTool and FddPackage deployments. [1] [2]

PR Context

This property is only for Mariner currently.
.NET tools are expected to respect DOTNET_ROOT. However, the package for Mariner should not use DOTNET_ROOT, but use a system defined dotnet runtime instead.
Self-Contained Deployments (SCD) installs don't support this new property.

PR Checklist

@microsoft-github-policy-service microsoft-github-policy-service bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 15, 2025
@TravisEz13
Copy link
Member Author

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Feb 20, 2025
@TravisEz13 TravisEz13 changed the title Add SDK search property Add Runtime search property Feb 25, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 25, 2025
@TravisEz13 TravisEz13 marked this pull request as ready for review February 25, 2025 20:38
@TravisEz13 TravisEz13 requested a review from a team as a code owner February 25, 2025 20:38
@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Mar 7, 2025
Copy link
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

TravisEz13 and others added 2 commits March 11, 2025 13:26
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
@jshigetomi jshigetomi mentioned this pull request Aug 11, 2025
12 tasks
@jshigetomi
Copy link
Collaborator

PR: #25837 Fixed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review - Needed The PR is being reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants