Put bareword_filehandles feature back into the v5.35 bundle
#19705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
d5c835d was the initial removal, which also changed some documentation in regen/feature.pl: I believe we need to revert that documentation change as well |
|
Ahyes. Rebased, reverted documentation in I'll squash it to a single commit before merge. |
wolfsage
approved these changes
May 13, 2022
|
Thanks, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is due to bug #19704, where it doesn't work properly.
It's far too close to 5.36 release to have a go at fixing it now, so the best we can do put the named feature back into the version bundle and see about fixing it next time.
We should probably also add some release notes somewhere saying that explicitly disabling it will run into this same bug, so probably advise don't do that.