[iluvatar_gpu] Adapt for iluvatar gpu #2684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
26dc70f to
22dc404
Compare
yongqiangma
reviewed
Jul 4, 2025
| @@ -0,0 +1,55 @@ | |||
|
|
|||
| /* Copyright (c) 2024 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
有一些文件没有加Copyright，加一下，然后改一下这里的20024→2025吧
yongqiangma
reviewed
Jul 4, 2025
custom_ops/iluvatar_ops/helper.h
Outdated
| #include <sys/types.h> | ||
| #include <unistd.h> | ||
|
|
||
| #ifdef PADDLE_WITH_HIP |
d1a3f6b to
c0a1314
Compare
|
代码看下来没什么问题，希望PR描述、标题可以补充更多信息。比如在PR描述中给出当前的支持进度、适配局限性、后续适配计划等等，当然可能也包括对FastDeploy在硬件适配方面的一些意见，相信这是飞桨与天数智芯在大模型推理方向合作的一个里程碑，后续一定会有更多适配和维护计划～ |
yuanlehome
previously approved these changes
Jul 7, 2025
|
代码冲突需要解决一下，解决后我可以来帮忙Approve与合入 @liddk |
yuanlehome
reviewed
Jul 7, 2025
fastdeploy/platforms/iluvatar.py
Outdated
Comment on lines
29
to
32
| elif selected_backend == _Backend.APPEND_ATTN: | ||
| return ( | ||
| "fastdeploy.model_executor.layers.attention.IluvatarAttnBackend" | ||
| ) |
There was a problem hiding this comment.
这个最好通过env设定FD_ATTENTION_BACKEND为ILUVATAR_ATTN来控制，借用APPEND_ATTN不太合理
There was a problem hiding this comment.
Updated, 只返回固定的IluvatarAttnBackend
yuanlehome
reviewed
Jul 7, 2025
fastdeploy/platforms/base.py
Outdated
| @@ -63,6 +63,12 @@ def is_dcu(self) -> bool: | |||
| """ | |||
| return paddle.is_compiled_with_rocm() | |||
|
|
|||
| def is_iluvatar(self) -> bool: | |||
| """ | |||
| whether platform is npu | |||
yongqiangma
previously approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目前FD已在天数硬件上完成兼容适配。
依赖适配的版本信息如下：
天数sdk：4.3.0
PaddlePaddle：3.1.0
Paddle Iluvatar GPU: 4.3.0
当前版本为体验版本，更多的性能优化和模型支持请期待后续PR。