Add possibility to prevent navigation away from current domain or page #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SRWieZ @gwleuverink I am not entirely sure with this PR and would like to know your thoughts on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to restrict navigation within a window so that the user cannot navigate away from the current domain or page.
When implementing kiosk-type applications, you may want to give users access to certain pages or domains that are not directly under your control. In such cases, users may be able to navigate away from the page they are viewing, which is often undesirable.
This PR introduces two new methods on the
Windowfacade which allow you to restrict in-window navigation.preventLeaveDomainwould allow the user to navigate within the original host name.preventLeavePagewould restrict any navigation (except anchors or URL parameters).Electron PR: NativePHP/electron#250