Skip to content

Fix iOS 13 depraction, fix Swiftlint and Danger on PRs #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 10, 2022
Merged

Fix iOS 13 depraction, fix Swiftlint and Danger on PRs #1715

merged 5 commits into from
May 10, 2022

Conversation

Kaspik
Copy link
Member

@Kaspik Kaspik commented May 10, 2022

  • add valid swiftlint config
  • fix Danger and swiftlint on PRs
  • fix iOS 13 showMenu depraction

@Kaspik Kaspik requested a review from martinpucik May 10, 2022 14:53
@github-actions
Copy link

github-actions bot commented May 10, 2022 •
edited
Loading

1 Warning
⚠️ Sources/Controllers/MessagesViewController+Menu.swift#L71 - Force unwrapping should be avoided.
force_unwrapping MessagesViewController+Menu.swift:71

Generated by 🚫 Danger

@Kaspik Kaspik enabled auto-merge May 10, 2022 15:03
martinpucik
martinpucik approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@martinpucik martinpucik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Kaspik Kaspik merged commit 0f6b4c2 into main May 10, 2022
@Kaspik Kaspik deleted the swiftlint branch May 10, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpucik martinpucik martinpucik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kaspik @martinpucik