Update to skiko 0.9.30 #2471
Update to skiko 0.9.30 #2471
Conversation
| /** | ||
| * Renders the dialog's content synchronously. | ||
| */ | ||
| fun renderImmediately() { |
There was a problem hiding this comment.
Why do we need it as public API here?
There was a problem hiding this comment.
It can be internal, but maybe we should allow someone using ComposeWindow/ComposeDialog directly the same abilities we have internally.
I will add more documentation and mark it experimental.
| /** | ||
| * Renders the dialog's content synchronously. | ||
| */ | ||
| fun renderImmediately() { |
There was a problem hiding this comment.
Are we ready to support backward compatibility in this shape?
There was a problem hiding this comment.
I made these functions experimental.
| } | ||
|
|
||
| /** | ||
| * Renders the dialog's content synchronously. |
There was a problem hiding this comment.
As for public documentation, it's not clear in what case it should be used
There was a problem hiding this comment.
Expanded the documentation.
|
Please add second reviewer for public API and update release notes |
|
Adding Victor as reviewer, as this adds a new public API |
Update to skiko 0.9.30
See related changes in skiko.
Fixes https://youtrack.jetbrains.com/issue/CMP-8956
Release Notes
Fixes - Desktop