Ignore control characters for accented character input on macOS. #2250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
approved these changes
Jul 16, 2025
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopTextInputService2.kt
Outdated
Show resolved
Hide resolved
61b2f06 to
2d8a4a4
Compare
igordmn
reviewed
Jul 16, 2025
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopTextInputService2.kt
Outdated
Show resolved
Hide resolved
2d8a4a4 to
bf44e41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the detection of accented character input on macOS to ignore control characters.
Before this change, it would react to e.g.
backspace, which would then interfere with composition, deleting parts of it.Fixes https://youtrack.jetbrains.com/issue/CMP-8184/InputMethod-input-breaks-after-pressing-backspace
Testing
Tested manually and added a new
WindowTypeTest.This should be tested by QA
Release Notes
Fixes - Desktop