My work #4
Open
My work #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshemsedinov
requested changes
Dec 16, 2019
Exercises/1-callback.js
Outdated
| callback(new Error('obj needed')); | ||
| return; | ||
| } | ||
| for (const key in obj) { |
There was a problem hiding this comment.
This will iterate all object keys plus inherited keys from prototype chain.
Exercises/3-wrapper.js
Outdated
| const contract = (fn, ...types) => null; | ||
| const contract = (fn, ...types) => (...arr) => { | ||
| for (let i = 1; i < types.length - 1; i++) { | ||
| if (typeof fn(...arr) !== types[i].name.toLowerCase()) { |
There was a problem hiding this comment.
Use intermediate variables
Exercises/3-wrapper.js
Outdated
| throw new TypeError('Types are different'); | ||
| } | ||
| } | ||
| return fn(...arr); |
There was a problem hiding this comment.
Last argument is a result type.
There was a problem hiding this comment.
Check result type after calling fn
|
Please rebase on master to activate CI |
tshemsedinov
requested changes
Dec 16, 2019
Exercises/3-wrapper.js
Outdated
| throw new TypeError('Types are different'); | ||
| } | ||
| } | ||
| return fn(...arr); |
There was a problem hiding this comment.
Check result type after calling fn
Exercises/3-wrapper.js
Outdated
| if (argType !== neededArgType) { | ||
| throw new TypeError('Types are different'); | ||
| } | ||
| if (resultType !== neededReType) { |
There was a problem hiding this comment.
Why do you check result types in loop?
|
'use strict';
const contract = (fn, ...types) => (...arr) => {
for (let i = 0; i < types.length - 1; i++) {
const argType = typeof arr[i];
const neededArgType = types[i].name.toLowerCase();
if (argType !== neededArgType) {
throw new TypeError('Types are different');
}
}
const neededReType = types[types.length - 1].name.toLowerCase();
const result = fn(...arr);
if (typeof result !== neededReType) {
throw new TypeError('Types are different');
}
return result;
};
module.exports = { contract };
Is it correct now?
…On Mon, 16 Dec 2019 at 21:28, Timur Shemsedinov ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In Exercises/3-wrapper.js
<#4 (comment)>
:
> @@ -1,5 +1,13 @@
'use strict';
-const contract = (fn, ...types) => null;
+const contract = (fn, ...types) => (...arr) => {
+ for (let i = 1; i < types.length - 1; i++) {
+ if (typeof fn(...arr) !== types[i].name.toLowerCase()) {
+ throw new TypeError('Types are different');
+ }
+ }
+ return fn(...arr);
Check result type after calling fn
------------------------------
In Exercises/3-wrapper.js
<#4 (comment)>
:
> @@ -1,5 +1,21 @@
'use strict';
-const contract = (fn, ...types) => null;
+const contract = (fn, ...types) => (...arr) => {
+ const resultType = typeof fn(...arr);
+ const neededReType = types[types.length - 1].name.toLowerCase();
+ for (let i = 0; i < types.length - 1; i++) {
+ const argType = typeof arr[i];
+ const neededArgType = types[i].name.toLowerCase();
+ if (argType !== neededArgType) {
+ throw new TypeError('Types are different');
+ }
+ if (resultType !== neededReType) {
Why do you check result types in loop?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4?email_source=notifications&email_token=AMXNJKMGX2D4ZWJAGXUE6R3QY7JFFA5CNFSM4J3DL4S2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPLBF3Y#pullrequestreview-332796655>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMXNJKKZDZXCRQH47WYLZRDQY7JFFANCNFSM4J3DL4SQ>
.
|
|
Please don't send changes in email, commit it directly to git because I need to see diff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.