Skip to content

Revert "displaylink: undeprecate" #224357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

Revert "displaylink: undeprecate" #224357

merged 1 commit into from
Aug 18, 2025

Conversation

bevanjkay
Copy link
Member

Reverts #224086

daeho-ro
daeho-ro approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@daeho-ro daeho-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's wrong?

@bevanjkay
Copy link
Member Author

The DSL isn't supported in the API.

@bevanjkay bevanjkay added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Aug 18, 2025
@bevanjkay bevanjkay enabled auto-merge August 18, 2025 11:17
@bevanjkay bevanjkay added this pull request to the merge queue Aug 18, 2025
Merged via the queue into main with commit aed3eda Aug 18, 2025
15 of 18 checks passed
@bevanjkay bevanjkay deleted the revert-224086-displaylink-update branch August 18, 2025 11:26
@jasonlyle88
Copy link

While this reverts #224086 which introduced the change from the preflight to the rename that caused this issue, this also reverted the undeprecation of the displaylink cask. Can another PR be created that only removes the disable! directive since that has been determined to have been incorrectly applied?

@bevanjkay
Copy link
Member Author

The audit will continue to fail until the new rename dsl is available properly with the next release. So it will need to wait until then.

@ashokm ashokm mentioned this pull request Aug 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daeho-ro daeho-ro daeho-ro approved these changes

Assignees
No one assigned
Labels
cask disabled Cask disabled ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. unsigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bevanjkay @jasonlyle88 @daeho-ro @BrewTestBot