Limit search pattern and directory recursion #4647
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
da62f4a to
86ca875
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
86ca875 to
3693ec5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
3693ec5 to
f37a27d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the project file discovery mechanism by limiting the scope and depth of directory traversal to prevent infinite loops and PathTooLongException errors. The changes specifically target scenarios where directory recursion could become problematic.
- Introduces a maximum recursion depth limit of 255 subdirectories
- Narrows the search pattern from "*" to "*proj" to focus on actual project files
- Replaces the legacy
SearchOption.AllDirectorieswith modernEnumerationOptions
Narrow the scope of the search pattern to only include project files and limit directory recursion to 255 subdirectories to avoid infinite loops and subsequent `PathTooLongException`. May fix GitToolsGH-4411.
f37a27d to
b857ada
Compare
|
|
Thank you @asbjornu for your contribution! |
|
🎉 This issue has been resolved in version 6.4.0 🎉 Your GitReleaseManager bot 📦🚀 |
Description
Narrow the scope of the search pattern to only include project files and limit directory recursion to 255 subdirectories to avoid infinite loops and subsequent
PathTooLongException.Related Issue
May fix GH-4411.
Checklist: