Format the commitMsg so it doesn't break PlantUml #4590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asbjornu
approved these changes
Jun 23, 2025
|
I wouldn't mind a test for this, but I don't think it's very important either. The code is rather trivial and this is a part of GitVersion that I'd almost say is "unsupported". :) |
|
Merging. If you want to write some tests for this, please submit them in a new PR. :) |
|
Thank you @9swampy for your contribution! |
|
@asbjornu is this also closing the reference issue? if so please include the issue in the milestore |
|
🎉 This issue has been resolved in version 6.4.0 🎉 Your GitReleaseManager bot 📦🚀 |
This was referenced Aug 11, 2025
This was referenced Aug 18, 2025
This was referenced Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test scenarios that generate UML output break PlantUml when the commit msg doesn't play nice.
Related Issue
#4585
Motivation and Context
I want to be able to copy paste from the scenario output without having to tidy upthe output.
How Has This Been Tested?
Refer to screenshot following. If you're interested I'll add test coverage of added code.
Screenshots (if appropriate):
Instead of this
Get this
Checklist: