-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Improve array decode #7342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
xunilrj
wants to merge
15
commits into
master
Choose a base branch
from
xunilrj/improve-array-decode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Improve array decode #7342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #7342 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation of #6860.
This PR implements multiple small features focusing on improving
AbiDecode
for arrays.1 - Before the implementation for
AbiDecode
for arrays was decoding the first element and creating an "repeat array". Depending on the size that would init with up to fivestore
or would loop copying the first item over all slots.Now we create an "repeat array" of zero of the required size. This will be initialized with just one
MCLI
/MCL
. And then we transmute this into the desired array type;2 - Array lengths can now be specified with
const
.One limitation is that these lengths must be limited to simple
const
variables. Associatedconsts
are still not working.Another limitation is that we can't unify arrays lengths that use variables and literals. For example:
let _: [u64; 1] = [0u64; A]
;3 -
const
declarations can now useconst generics
in its expressions.4 -
__transmute
can now transmute references.convert_resolved_type_info
One of the biggest changes was that now
convert_resolved_type_info
needs to access the "context" that is being compiled, as the type can include expressions. At the moment onlyconst variables
andconst generics variables
. But soon enough we will be able to write expressions and it needs full access to available symbols.Checklist
Breaking*
orNew Feature
labels where relevant.