gd options and other (check desc) #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added EVERY gd option (in the options page) && in-game resolutions && in-game LDM (Low Detail Mode) && Vertical Sync Check && Smooth Fix Check && PlayerGlow
Folleach
reviewed
Oct 7, 2023
GeometryDashAPI/Data/GameData.cs
Outdated
| DataPlist = new Plist(Encoding.ASCII.GetBytes(resultPlist)); | ||
| } | ||
| var xor = Crypt.XOR(data, 0xB); | ||
| var index = xor.GetIndexOfNullByte(); |
There was a problem hiding this comment.
It can be implemented easier and will be even faster
xor.AsSpan().IndexOf((byte)0)Because inside IndexOf use a simd instructions.
Proof:
using System;
using System.Linq;
using BenchmarkDotNet.Attributes;
namespace GeometryDashAPI.Benchmarks.Benchmarks;
[MemoryDiagnoser]
public class IndexOfBenchmark
{
private static readonly byte[] data = Enumerable.Range(0, 4096)
.Select(x => (byte)(1 + (byte)(x % 250)))
.Concat(new byte[] { 0 })
.ToArray();
[Benchmark]
public int IndexOf() => data.AsSpan().IndexOf((byte)0);
[Benchmark]
public int GetIndexOfNullByte() => data.GetIndexOfNullByte();
}| Method | Mean | Error | StdDev | Allocated |
|---|---|---|---|---|
| IndexOf | 84.86 ns | 1.939 ns | 5.657 ns | - |
| GetIndexOfNullByte | 2,244.83 ns | 38.261 ns | 35.789 ns | - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added EVERY gd option (in the options page)
&& in-game resolutions
&& in-game LDM (Low Detail Mode)
&& Vertical Sync Check
&& Smooth Fix Check
&& PlayerGlow