-
Notifications
You must be signed in to change notification settings - Fork 166
feat: Adopted changes for kubectl cp command #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, will check test results then can probably get merged by end of day today w/ a new release.
Edit @Gokul-Mylsami - can you fix up test failure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR and for including the unit tests—great work on that!
That said, I’d prefer if these commands were integrated as part of the existing kubectl_generic
tool. We currently have 21 tools exposed, and our longer-term goal is to consolidate rather than expand the toolset. Introducing additional tools could unnecessarily increase the context window size for the LLM Agent, impacting performance.
Would you be open to adjusting your unit tests to use the kubectl_generic
command instead? This would help us avoid introducing a new standalone tool while still achieving the intended functionality.
e.g. You will need some adjustment in kubectl_generic's tools description.
Thanks for the feedback, @rr-paras-patel. I will make the changes accordingly |
@rr-paras-patel I'm not against having a separate cp command instead of overloading generic. Couple of reasons:
The other thing is that if we're worried about context from tool calls, we should add that to our CI / CD and measure it for every change - then can make pretty simple data driven decisions (context over X tokens means we need to reduce / refactor, etc.). In this case I don't actually know how many tokens all our tool calls are using or the additional tokens a single tool call / PR is adding (I'm guessing ~90-100?). If this was being developed for a company, I would say just add anonymized telemetry so that we could add this feature, see it's usage, and then decide in a future version (~4-5 weeks) if we wanted to remove it because most LLMs are actually using the Either way - super long wall of text, but I don't think we need to reject only because there's a new tool call / because of context size. |
ok, let's move forward with new tool then. while VS Code do have capability to enable selected tools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per discussion in thread lets keep this tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted to the kubectl-cp tool
@Flux159 ,I am facing an issue with the GitHub workflow tests, whereas they are working fine on my local machine. I am debugging the issue. |
@Gokul-Mylsami You're able to see the errors right?
Unclear if this is related to this. I don't think that minikube should be an issue here? |
This reverts commit 0b08092.
…ding for pod file access
Adopted Support for kubectl cp Command and Added Test Cases