Skip to content

k8s Security analysis tool #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

k8s Security analysis tool #145

wants to merge 4 commits into from

Conversation

pt-vamshi
Copy link

No description provided.

@pt-vamshi pt-vamshi mentioned this pull request May 25, 2025
Open
Flux159
Flux159 reviewed May 25, 2025
View reviewed changes
Copy link
Owner

@Flux159 Flux159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍, can you add a test for this feature?

Can mock the results for each of the checks & validate that the tool call returns what you expect.

@rr-paras-patel any other thoughts since this addresses #136

@rr-paras-patel
Copy link
Collaborator

rr-paras-patel commented May 27, 2025 •
edited
Loading

@pt-vamshi this is nice start. but i would prefer MCP Prompt for such multi step operation. also there is not many clients yet supporting prompts so we can keep it available same function for Tools and Prompt both what do you think ?

@rr-paras-patel
Copy link
Collaborator

rr-paras-patel commented Jun 11, 2025 •
edited
Loading

@pt-vamshi we can merge your PR with as additional tool for now. and later we can add prompt support. please add some test cases.

@pt-vamshi
Copy link
Author

@pt-vamshi we can merge your PR with as additional tool for now. and later we can add prompt support. please add some test cases.

okay thanks

@rr-paras-patel
Copy link
Collaborator

rr-paras-patel commented Jun 16, 2025 •
edited
Loading

@pt-vamshi this is what i was expecting.
#156
Please add merge conflicts on your branch.

@pt-vamshi
Copy link
Author

@pt-vamshi this is what i was expecting. #156 Please add merge conflicts on your branch.

fixed conflict

@Flux159
Copy link
Owner

Flux159 commented Jun 16, 2025

@pt-vamshi Build is failing with this PR

Run bun run build
$ tsc && shx chmod +x dist/*.js
src/index.ts(58,10): error TS2300: Duplicate identifier 'kubectlRollout'.
src/index.ts(58,2[6](https://github.com/Flux159/mcp-server-kubernetes/actions/runs/15673648222/job/44205269129#step:9:7)): error TS2300: Duplicate identifier 'kubectlRolloutSchema'.
src/index.ts([7](https://github.com/Flux159/mcp-server-kubernetes/actions/runs/15673648222/job/44205269129#step:9:8)2,3): error TS2300: Duplicate identifier 'kubectlRollout'.
src/index.ts(73,3): error TS2300: Duplicate identifier 'kubectlRolloutSchema'.

Also, still want to get tests for this command before approving. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flux159 Flux159 Flux159 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pt-vamshi @rr-paras-patel @Flux159