Skip to content

Tags: FlutterNexus/flutter-embedded-linux

Tags

a18df97ca5

Toggle a18df97ca5's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Ensure FlutterDesktopViewControllerState declares default destructor (s…

…ony#428)

types containing std::unique_ptr to incomplete types require a destructor to be
defined as the size is unavailable, otherwise the following error is raised at
compile time:

/usr/lib/gcc/aarch64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:97:16: error: invalid application of 'sizeof' to an incomplete type 'flutter::FlutterELinuxView'
  91 |       _GLIBCXX23_CONSTEXPR
  92 |       void
  93 |       operator()(_Tp* __ptr) const
     |       `- note: in instantiation of member function 'std::default_delete<flutter::FlutterELinuxView>::operator()' requested here
  94 |       {
  95 | 	static_assert(!is_void<_Tp>::value,
  96 | 		      "can't delete pointer to incomplete type");
  97 | 	static_assert(sizeof(_Tp)>0,
     |                `- error: invalid application of 'sizeof' to an incomplete type 'flutter::FlutterELinuxView'
  98 | 		      "can't delete pointer to incomplete type");
  99 | 	delete __ptr;

Signed-off-by: Luke Howard <lukeh@padl.com>

db49896cf2

Toggle db49896cf2's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Destroy textures on raster thread (sony#427)

* Destroy textures on raster thread

Signed-off-by: Bari Rao <bari.rao@gmail.com>

* Fix format

Signed-off-by: Bari Rao <bari.rao@gmail.com>

---------

Signed-off-by: Bari Rao <bari.rao@gmail.com>

36335019a8

Toggle 36335019a8's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Removed unused variable (sony#423)

235db911ba

Toggle 235db911ba's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Add libuv support as a replacement of systemd + some CMake fixes (son…

…y#420)

* git: prevent accidental push on generated files

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: fix wrong option usage

The option() function only dedicated for boolean type. For enumerated string, better use both set(... CACHE STRING ...) and set_property(CACHE ... PROPERTY STRINGS ...).

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: fix wrong string cache syntax in set()

For further information, visit the documentation at https://cmake.org/cmake/help/latest/command/set.html#set-cache-entry

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: warn if BUILD_ELINUX_SO is OFF but BACKEND_TYPE was modified

This commit prevents other new contributors from mistakenly blame CMakeLists.txt. Therefore, I added a warning just in case they forgot to turn on BUILD_ELINUX_SO while modifying BACKEND_TYPE.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: enforce regex exactness for safety

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* drm: add libuv support as systemd replacement

Not all embedded systems can include systemd due to their constrained resource limit. Our requirement from libsystemd is only event loop (sd-event). Therefore, libuv is perfect as drop-in replacement of sd-event. I tested the changes on Raspberry Pi 5 with Buildroot (yes, I am working on it too) and a x86-64 laptop with Arch Linux. Both are working as intended. Interestingly, libuv makes flutter-elinux smoother on my laptop. I have no idea how to benchmark it, but it is a good sign for us.

For now, I am assuming users are still relying on libsystemd. Therefore, libuv only be used if the target device has no systemd. If maintainer want to drop the systemd dependency, I suggest to deprecate it gracefully and plan to drop it later. Otherwise, it would be a breaking change.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* author: add Athaariq Ardhiansyah

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* style: overhaul to comply the standard

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* style: format with clang-format v14.0.6

I realized that clang-format is inconsistent between its versions. So, Arch Linux (clang v17) and Ubuntu Jammy (clang v14) will output different formatting result. For Arch Linux users, the clang14 package has no clang-format included. You need to compile the entire clang on your own until the downstream maintainer include it.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: fix error for CMake before v3.28

On some distributions with non-latest CMake, it will fail on configuration due to its incapability of substition from unset variable to an empty string. To fix this, we need to add double quotes between variables that will be tested by EQUAL, LESS, GREATER, and other related keywords. For better compatibility, use STREQUAL instead of EQUAL if possible.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

---------

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

edd8546116

Toggle edd8546116's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Add libuv support as a replacement of systemd + some CMake fixes (son…

…y#420)

* git: prevent accidental push on generated files

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: fix wrong option usage

The option() function only dedicated for boolean type. For enumerated string, better use both set(... CACHE STRING ...) and set_property(CACHE ... PROPERTY STRINGS ...).

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: fix wrong string cache syntax in set()

For further information, visit the documentation at https://cmake.org/cmake/help/latest/command/set.html#set-cache-entry

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: warn if BUILD_ELINUX_SO is OFF but BACKEND_TYPE was modified

This commit prevents other new contributors from mistakenly blame CMakeLists.txt. Therefore, I added a warning just in case they forgot to turn on BUILD_ELINUX_SO while modifying BACKEND_TYPE.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: enforce regex exactness for safety

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* drm: add libuv support as systemd replacement

Not all embedded systems can include systemd due to their constrained resource limit. Our requirement from libsystemd is only event loop (sd-event). Therefore, libuv is perfect as drop-in replacement of sd-event. I tested the changes on Raspberry Pi 5 with Buildroot (yes, I am working on it too) and a x86-64 laptop with Arch Linux. Both are working as intended. Interestingly, libuv makes flutter-elinux smoother on my laptop. I have no idea how to benchmark it, but it is a good sign for us.

For now, I am assuming users are still relying on libsystemd. Therefore, libuv only be used if the target device has no systemd. If maintainer want to drop the systemd dependency, I suggest to deprecate it gracefully and plan to drop it later. Otherwise, it would be a breaking change.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* author: add Athaariq Ardhiansyah

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* style: overhaul to comply the standard

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* style: format with clang-format v14.0.6

I realized that clang-format is inconsistent between its versions. So, Arch Linux (clang v17) and Ubuntu Jammy (clang v14) will output different formatting result. For Arch Linux users, the clang14 package has no clang-format included. You need to compile the entire clang on your own until the downstream maintainer include it.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: fix error for CMake before v3.28

On some distributions with non-latest CMake, it will fail on configuration due to its incapability of substition from unset variable to an empty string. To fix this, we need to add double quotes between variables that will be tested by EQUAL, LESS, GREATER, and other related keywords. For better compatibility, use STREQUAL instead of EQUAL if possible.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

---------

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

c9b9d5780d

Toggle c9b9d5780d's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Add libuv support as a replacement of systemd + some CMake fixes (son…

…y#420)

* git: prevent accidental push on generated files

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: fix wrong option usage

The option() function only dedicated for boolean type. For enumerated string, better use both set(... CACHE STRING ...) and set_property(CACHE ... PROPERTY STRINGS ...).

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: fix wrong string cache syntax in set()

For further information, visit the documentation at https://cmake.org/cmake/help/latest/command/set.html#set-cache-entry

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: warn if BUILD_ELINUX_SO is OFF but BACKEND_TYPE was modified

This commit prevents other new contributors from mistakenly blame CMakeLists.txt. Therefore, I added a warning just in case they forgot to turn on BUILD_ELINUX_SO while modifying BACKEND_TYPE.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: enforce regex exactness for safety

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* drm: add libuv support as systemd replacement

Not all embedded systems can include systemd due to their constrained resource limit. Our requirement from libsystemd is only event loop (sd-event). Therefore, libuv is perfect as drop-in replacement of sd-event. I tested the changes on Raspberry Pi 5 with Buildroot (yes, I am working on it too) and a x86-64 laptop with Arch Linux. Both are working as intended. Interestingly, libuv makes flutter-elinux smoother on my laptop. I have no idea how to benchmark it, but it is a good sign for us.

For now, I am assuming users are still relying on libsystemd. Therefore, libuv only be used if the target device has no systemd. If maintainer want to drop the systemd dependency, I suggest to deprecate it gracefully and plan to drop it later. Otherwise, it would be a breaking change.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* author: add Athaariq Ardhiansyah

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* style: overhaul to comply the standard

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* style: format with clang-format v14.0.6

I realized that clang-format is inconsistent between its versions. So, Arch Linux (clang v17) and Ubuntu Jammy (clang v14) will output different formatting result. For Arch Linux users, the clang14 package has no clang-format included. You need to compile the entire clang on your own until the downstream maintainer include it.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: fix error for CMake before v3.28

On some distributions with non-latest CMake, it will fail on configuration due to its incapability of substition from unset variable to an empty string. To fix this, we need to add double quotes between variables that will be tested by EQUAL, LESS, GREATER, and other related keywords. For better compatibility, use STREQUAL instead of EQUAL if possible.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

---------

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

b8800d88be

Toggle b8800d88be's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Add libuv support as a replacement of systemd + some CMake fixes (son…

…y#420)

* git: prevent accidental push on generated files

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: fix wrong option usage

The option() function only dedicated for boolean type. For enumerated string, better use both set(... CACHE STRING ...) and set_property(CACHE ... PROPERTY STRINGS ...).

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: fix wrong string cache syntax in set()

For further information, visit the documentation at https://cmake.org/cmake/help/latest/command/set.html#set-cache-entry

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: warn if BUILD_ELINUX_SO is OFF but BACKEND_TYPE was modified

This commit prevents other new contributors from mistakenly blame CMakeLists.txt. Therefore, I added a warning just in case they forgot to turn on BUILD_ELINUX_SO while modifying BACKEND_TYPE.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: enforce regex exactness for safety

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* drm: add libuv support as systemd replacement

Not all embedded systems can include systemd due to their constrained resource limit. Our requirement from libsystemd is only event loop (sd-event). Therefore, libuv is perfect as drop-in replacement of sd-event. I tested the changes on Raspberry Pi 5 with Buildroot (yes, I am working on it too) and a x86-64 laptop with Arch Linux. Both are working as intended. Interestingly, libuv makes flutter-elinux smoother on my laptop. I have no idea how to benchmark it, but it is a good sign for us.

For now, I am assuming users are still relying on libsystemd. Therefore, libuv only be used if the target device has no systemd. If maintainer want to drop the systemd dependency, I suggest to deprecate it gracefully and plan to drop it later. Otherwise, it would be a breaking change.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* author: add Athaariq Ardhiansyah

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* style: overhaul to comply the standard

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* style: format with clang-format v14.0.6

I realized that clang-format is inconsistent between its versions. So, Arch Linux (clang v17) and Ubuntu Jammy (clang v14) will output different formatting result. For Arch Linux users, the clang14 package has no clang-format included. You need to compile the entire clang on your own until the downstream maintainer include it.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: fix error for CMake before v3.28

On some distributions with non-latest CMake, it will fail on configuration due to its incapability of substition from unset variable to an empty string. To fix this, we need to add double quotes between variables that will be tested by EQUAL, LESS, GREATER, and other related keywords. For better compatibility, use STREQUAL instead of EQUAL if possible.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

---------

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

a6bd3f1de1

Toggle a6bd3f1de1's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Add libuv support as a replacement of systemd + some CMake fixes (son…

…y#420)

* git: prevent accidental push on generated files

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: fix wrong option usage

The option() function only dedicated for boolean type. For enumerated string, better use both set(... CACHE STRING ...) and set_property(CACHE ... PROPERTY STRINGS ...).

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: fix wrong string cache syntax in set()

For further information, visit the documentation at https://cmake.org/cmake/help/latest/command/set.html#set-cache-entry

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: warn if BUILD_ELINUX_SO is OFF but BACKEND_TYPE was modified

This commit prevents other new contributors from mistakenly blame CMakeLists.txt. Therefore, I added a warning just in case they forgot to turn on BUILD_ELINUX_SO while modifying BACKEND_TYPE.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: enforce regex exactness for safety

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* drm: add libuv support as systemd replacement

Not all embedded systems can include systemd due to their constrained resource limit. Our requirement from libsystemd is only event loop (sd-event). Therefore, libuv is perfect as drop-in replacement of sd-event. I tested the changes on Raspberry Pi 5 with Buildroot (yes, I am working on it too) and a x86-64 laptop with Arch Linux. Both are working as intended. Interestingly, libuv makes flutter-elinux smoother on my laptop. I have no idea how to benchmark it, but it is a good sign for us.

For now, I am assuming users are still relying on libsystemd. Therefore, libuv only be used if the target device has no systemd. If maintainer want to drop the systemd dependency, I suggest to deprecate it gracefully and plan to drop it later. Otherwise, it would be a breaking change.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* author: add Athaariq Ardhiansyah

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* style: overhaul to comply the standard

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* style: format with clang-format v14.0.6

I realized that clang-format is inconsistent between its versions. So, Arch Linux (clang v17) and Ubuntu Jammy (clang v14) will output different formatting result. For Arch Linux users, the clang14 package has no clang-format included. You need to compile the entire clang on your own until the downstream maintainer include it.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

* cmake: fix error for CMake before v3.28

On some distributions with non-latest CMake, it will fail on configuration due to its incapability of substition from unset variable to an empty string. To fix this, we need to add double quotes between variables that will be tested by EQUAL, LESS, GREATER, and other related keywords. For better compatibility, use STREQUAL instead of EQUAL if possible.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

---------

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

55eae6864b

Toggle 55eae6864b's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
embedder: merge embedder.h from flutter/engine (sony#416)

Merged from https://github.com/flutter/engine/commits/3.22.0/shell/platform/embedder/embedder.h

Signed-off-by: Hidenori Matsubayashi <Hidenori.Matsubayashi@gmail.com>

f6344b75dc

Toggle f6344b75dc's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
wayland: text input protocol uses UTF-8 encoding (sony#415)

* wayland: text input protocol uses UTF-8 encoding

The Wayland text input protocol sends text in
UTF-8 encoding, but the Flutter TextInputModel
expects UTF-16.

This adds the missing conversion from UTF-8 to
UTF-16.

Signed-off-by: Sebastian Urban <surban@surban.net>

* Add Sebastian Urban to AUTHORS

---------

Signed-off-by: Sebastian Urban <surban@surban.net>