Skip to content
This repository was archived by the owner on Mar 25, 2024. It is now read-only.

Add additional type information #25

Merged
merged 30 commits into from
Oct 22, 2021
Merged

Add additional type information #25

merged 30 commits into from
Oct 22, 2021

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Oct 22, 2021

This adds a lot of additional type information throughout the library, most to help with static analysis. Adds one additional interface, KeyHandleInterface, for similar reasons.

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #25 (e3bc343) into master (0b03072) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master       #25   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       101       101           
===========================================
  Files             18        18           
  Lines            349       350    +1     
===========================================
+ Hits             349       350    +1     
Impacted Files Coverage Δ
src/AppIdTrait.php 100.00% <ø> (ø)
src/AttestationCertificate.php 100.00% <ø> (ø)
src/ECPublicKey.php 100.00% <ø> (ø)
src/RegisterResponse.php 100.00% <ø> (ø)
src/ResponseTrait.php 100.00% <ø> (ø)
src/SignRequest.php 100.00% <ø> (ø)
src/VersionTrait.php 100.00% <ø> (ø)
src/ChallengeTrait.php 100.00% <100.00%> (ø)
src/ClientData.php 100.00% <100.00%> (ø)
src/Server.php 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b03072...e3bc343. Read the comment docs.

@Firehed Firehed marked this pull request as ready for review October 22, 2021 20:47
@Firehed Firehed merged commit 82529e2 into master Oct 22, 2021
@Firehed Firehed deleted the types branch October 22, 2021 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant