Skip to content
This repository was archived by the owner on Mar 25, 2024. It is now read-only.

Update dependencies, cleanup #12

Merged
merged 11 commits into from
May 27, 2019
Merged

Update dependencies, cleanup #12

merged 11 commits into from
May 27, 2019

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented May 27, 2019

The next version of the library will require PHP 7.2, so this pulls in newer versions of dev dependencies and updates the code and tests to be compatible with them.

Notably:

  • Numerous new PHPStan errors were caught and fixed (mostly json_decode related)
  • PHPUnit setUp is now explicitly void
  • The questionable workarounds to mbstring.func_overload > 0 have been removed, as the directive has been deprecated in PHP. This library is now straight-up incompatible with the setting, and will throw an exception if the setting is detected.

So far this makes to actual breaking changes in sanely-configured environments.

@coveralls
Copy link

coveralls commented May 27, 2019

Coverage Status

Coverage increased (+1.1%) to 99.265% when pulling 3d0b228 on dependencies into 65bb799 on master.

@Firehed Firehed merged commit 37656ad into master May 27, 2019
@Firehed Firehed deleted the dependencies branch May 27, 2019 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants