Skip to content

Update 20250116001415_add_wavoip_token_to_settings_table #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

caiquezanetoni
Copy link

@caiquezanetoni caiquezanetoni commented Aug 18, 2025

Ao trabalhar com vários schemas no postgres a verificação antiga falhava.
Exemplo:
Ao executar as migrations no banco de dados evolution (schema1) a coluna era criada.
Ao executar as migrations no banco de dados evolution (schema2) a coluna não era criada.

Dessa forma usando ADD COLUMN IF NOT EXISTS ela é criada todos os schemas.

Summary by Sourcery

Enhancements:

  • Use ALTER TABLE ADD COLUMN IF NOT EXISTS for the wavoipToken column instead of a DO block with information_schema check

Copy link
Contributor

sourcery-ai bot commented Aug 18, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactored the migration to replace the procedural column-existence check with a single ALTER TABLE ADD COLUMN IF NOT EXISTS statement, ensuring the wavoipToken column is added across all schemas without custom PL/pgSQL logic.

Entity relationship diagram for updated Setting table migration

erDiagram
    Setting {
        VARCHAR(100) wavoipToken
    }
Loading

File-Level Changes

Change Details Files
Switch from manual PL/pgSQL existence check to built-in conditional column addition
  • Removed DO $$...END $$ block
  • Eliminated SELECT query against information_schema.columns
  • Replaced ALTER TABLE with ADD COLUMN IF NOT EXISTS
  • Cleaned up migration script footer
prisma/postgresql-migrations/20250116001415_add_wavoip_token_to_settings_table/migration.sql

Possibly linked issues

  • #0: The PR ensures the 'wavoipToken' column is created across all schemas, directly addressing the missing column error in the issue.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@DavidsonGomes DavidsonGomes changed the base branch from main to develop August 22, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant