Skip to content

Replace hashicorp/yamux with xtaci/smux #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 31, 2018
Merged

Replace hashicorp/yamux with xtaci/smux #98

merged 22 commits into from
Oct 31, 2018

Conversation

auxten
Copy link
Contributor

@auxten auxten commented Oct 30, 2018 •
edited
Loading

  1. Replace hashicorp/yamux with xtaci/smux
  2. Fix proto.FindXXX.NodeID name collision with Envelope

@auxten auxten requested a review from zeqing-guo October 30, 2018 08:16
@codecov
Copy link

codecov bot commented Oct 30, 2018 •
edited
Loading

Codecov Report

Merging #98 into develop will decrease coverage by 0.33%.
The diff coverage is 65.3%.

@@             Coverage Diff             @@
##           develop      #98      +/-   ##
===========================================
- Coverage    76.78%   76.45%   -0.34%     
===========================================
  Files          147      147              
  Lines        11875    11874       -1     
===========================================
- Hits          9118     9078      -40     
- Misses        1824     1855      +31     
- Partials       933      941       +8

@auxten auxten changed the title Fix proto.FindXXX.NodeID name collision with Envelope Replace hashicorp/yamux with xtaci/smux Oct 31, 2018
zeqing-guo
zeqing-guo approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@zeqing-guo zeqing-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeqing-guo zeqing-guo merged commit 65bb9cf into develop Oct 31, 2018
This was referenced Oct 31, 2018
Closed
Closed
@leventeliu leventeliu deleted the feature/pprof branch December 29, 2018 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeqing-guo zeqing-guo zeqing-guo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@auxten @zeqing-guo