Skip to content

Minerd performance tuning #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 67 commits into from
Oct 29, 2018
Merged

Minerd performance tuning #95

merged 67 commits into from
Oct 29, 2018

Conversation

auxten
Copy link
Contributor

@auxten auxten commented Oct 25, 2018 •
edited
Loading

  1. Fix client conn PersistentCaller.Close, PersistentCaller.Call retry bugs
  2. Add PublicKey.UnmarshalBinary cache, add more unit tests for keypair
  3. Add ECDH shared secret cache by nodeID
  4. Add GrandLock in client driver for bench miner parallel
  5. Add query counter metric to graphite server
  6. Change default DSN _synchronous=NORMAL
  7. Add missing error check in PersistentCaller.Call
  8. Add multiple clients bench for BenchmarkMinerTwo
  9. Optimize out 4 useless signature verify
  10. Fix yamux session leak
  11. Add BenchmarkPersistentCaller_Call goroutine leak check
  12. Add default profileServer for http profiling
  13. Add runtime/trace for query
  14. Async ack sending after query
  15. Optimize out ack.Header verifying in ack.Sign()
  16. Add WaitToConnect, returns only when port is ready to connect or canceled by context.

auxten and others added 30 commits October 17, 2018 19:24
Add cleanupDB.sh in pprof.sh
a61b8a1
Add MarshalBinary UnmarshalBinary for NodeID
e097510
Add tags for messagepack size optimization
5c5a5fe
Fix client conn PersistentCaller.Close, PersistentCaller.Call retry bugs
17577a1
Add GrandLock in client driver for bench miner parallel
5ea0e0b
Add query counter metric to graphite server
badad4f
Add cyberdelia/go-metrics-graphite rcrowley/go-metrics to vendor
4c28285
Ignore test/covenantsql* temp dirs
132ba82
Change default DSN _synchronous=NORMAL
fdbd994
Add missing error check in PersistentCaller.Call
2b1be24
Add multiple clients bench for BenchmarkMinerTwo
fedabf3
Optimize out 3 useless signature verify
c5a393c
Optimize out Database.Query request.Verify
3a36720
Fix yamux session leak
d9a500e
Add BenchmarkPersistentCaller_Call goroutine leak check
ce4256d
Add .dsn ignore
4faf919
Add default profileServer for http profiling
54ef9af
Lower the connection closed log level to info
831e7c7
Add trace option for miner
e01c55b
Add trace for processNewLog processRequest
1e8ed79
Fix salt random buf generator in go-mysql package
3540a52
Fix peers signer bug
9fc19a0
Add peers signature process in hash upgrade hotfix
267c455
Fix bug in sqlchain block next block counter
40317b7
Add error to failed to check and push new block error
d6529f0
Add ECDH shared secret cache by nodeID
8bd9a47
Add PublicKey.UnmarshalBinary cache, add more unit tests for keypair
c42b6eb
Fix symmetricKeyCache bug
06c5863
Refactor client for DB object concurrent safety (esp. for connID/seqN…
e628892 
…o generation)
Fix client data race during testing
02af36a
covenantdb
covenantdb reviewed Oct 25, 2018
View reviewed changes
@codecov
Copy link

codecov bot commented Oct 25, 2018 •
edited
Loading

Codecov Report

Merging #95 into develop will increase coverage by 0.46%.
The diff coverage is 73.82%.

@@             Coverage Diff             @@
##           develop      #95      +/-   ##
===========================================
+ Coverage    75.95%   76.42%   +0.46%     
===========================================
  Files          147      147              
  Lines        11553    11693     +140     
===========================================
+ Hits          8775     8936     +161     
+ Misses        1845     1815      -30     
- Partials       933      942       +9

Qi Xiao and others added 14 commits October 25, 2018 17:11
Update variables setting and support show warnings in mysql adapter
3e08eec
Use empty result with non-nil row data for special queries
2dd9680
Add runtime.Caller return check
6f6fdcf
Ignore *.trace
cd6dd56
Merge remote-tracking branch 'origin/bugfix/mysqlAdapter' into featur…
7e21351 
…e/pprof
Add PersistentCaller.CloseStream func to close yamux.Session but pres…
fcfe571 
…erve underlying ETLS connection when called
Async ack sending after query
068bf32
Mute verbose log in CryptoConn.Read
6e61ee8
Optimize out ack.Header verifying in ack.Sign()
0942c2c
Lower BenchmarkMinerTwo benchtime=15s
772b1b4
Fix ack.Sign
ff788cf
Run go test ./... directly
39b6b1e
Add WaitToConnect, returns only when port is ready to connect or canc…
a8e57f5 
…eled by context.
Use utils.WaitToConnect instead of time.Sleep
cbef4e8
@auxten auxten changed the title WIP: Minerd performance tuning Minerd performance tuning Oct 27, 2018
xq262144
xq262144 approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xq262144 xq262144 merged commit 0b1435f into develop Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@covenantdb covenantdb covenantdb left review comments

@xq262144 xq262144 xq262144 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@auxten @xq262144 @covenantdb