Skip to content

Increase project test coverage and fix bugs in kayak #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 9, 2018

Conversation

xq262144
Copy link
Contributor

@xq262144 xq262144 commented Nov 9, 2018

  1. Increase project test coverage.
  2. Fix prepare log index leak in kayak.

@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #116 into develop will increase coverage by 5.14%.
The diff coverage is 61.76%.

@@            Coverage Diff             @@
##           develop    #116      +/-   ##
==========================================
+ Coverage    73.35%   78.5%   +5.14%     
==========================================
  Files          149     128      -21     
  Lines        12107    9857    -2250     
==========================================
- Hits          8881    7738    -1143     
+ Misses        2183    1514     -669     
+ Partials      1043     605     -438

@xq262144 xq262144 requested a review from leventeliu November 9, 2018 07:07
Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approve.

@leventeliu leventeliu merged commit 696be63 into develop Nov 9, 2018
@leventeliu leventeliu deleted the feature/kayakPerformance branch December 29, 2018 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants