Skip to content

Fix loadChain failure, remove the lock in sync() #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 8, 2018
Merged

Fix loadChain failure, remove the lock in sync() #114

merged 7 commits into from
Nov 8, 2018

Conversation

zeqing-guo
Copy link
Contributor

@zeqing-guo zeqing-guo commented Nov 8, 2018 •
edited
Loading

  1. loadChain will fail in bp because every load config, the chainInitTime will be reset. I simply remove the reset function.
  2. I also remove the lock in sync() to make block load faster. Because sync() executes first alone, it's ok to sync without locking runtime.
  3. Add go test option: -cpu 16

@zeqing-guo zeqing-guo requested review from leventeliu, auxten and xq262144 and removed request for leventeliu and auxten November 8, 2018 09:40
leventeliu
leventeliu approved these changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approve.

@leventeliu leventeliu merged commit 05d047f into develop Nov 8, 2018
@leventeliu leventeliu deleted the bugfix/loadchainFailed branch November 8, 2018 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leventeliu leventeliu leventeliu approved these changes

@xq262144 xq262144 Awaiting requested review from xq262144

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeqing-guo @leventeliu