Fix index out of bound, refactor part of sqlchain code #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d447a6 to
03389df
Compare
Codecov Report
@@ Coverage Diff @@
## develop #110 +/- ##
===========================================
+ Coverage 76.31% 76.32% +<.01%
===========================================
Files 149 149
Lines 11976 11981 +5
===========================================
+ Hits 9140 9144 +4
- Misses 1892 1893 +1
Partials 944 944 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
blockNodeis basically a struct of pointers and some native data types, I simply remove the preallocatedblockNodearray to prevent any further index fuckup.Some code refactoring is also introduced in this PR, please review with care.