Skip to content

Support lastInsertID/affectedRows in kayak #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2018
Merged

Conversation

xq262144
Copy link
Contributor

@xq262144 xq262144 commented Nov 6, 2018

Support last insert id/write operation affected rows returning in kayak and the final database product.

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #109 into develop will decrease coverage by 0.13%.
The diff coverage is 70.9%.

@@             Coverage Diff             @@
##           develop     #109      +/-   ##
===========================================
- Coverage    76.31%   76.18%   -0.14%     
===========================================
  Files          149      150       +1     
  Lines        11976    12404     +428     
===========================================
+ Hits          9140     9450     +310     
- Misses        1892     1991      +99     
- Partials       944      963      +19

Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we importing logrus again?

@xq262144
Copy link
Contributor Author

xq262144 commented Nov 6, 2018

@leventeliu The PR includes a whole dep update, which includes a newer logrus release embedded.

Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approve.

@leventeliu leventeliu merged commit 48b298e into develop Nov 6, 2018
@leventeliu leventeliu deleted the bugfix/kayakTwopc branch December 29, 2018 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants