Skip to content

Add call stack print for Error, Fatal and Panic #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Nov 4, 2018

Conversation

auxten
Copy link
Contributor

@auxten auxten commented Nov 1, 2018

  1. Wait for ping success before startDBMS
  2. Fix log position error when using WithXXX
  3. Make genesis block just one day ago in test mode
  4. Add call stack print for Error, Fatal and Panic

@auxten auxten requested a review from zeqing-guo November 1, 2018 09:09
@codecov
Copy link

codecov bot commented Nov 1, 2018

Codecov Report

Merging #108 into develop will increase coverage by 0.01%.
The diff coverage is 93.16%.

@@            Coverage Diff             @@
##           develop    #108      +/-   ##
==========================================
+ Coverage    76.18%   76.2%   +0.01%     
==========================================
  Files          148     149       +1     
  Lines        11889   11976      +87     
==========================================
+ Hits          9058    9126      +68     
- Misses        1887    1907      +20     
+ Partials       944     943       -1

@auxten auxten force-pushed the bugfix/logPosition branch from 7b92c15 to 1cb9eff Compare November 4, 2018 07:13
@auxten auxten changed the title Fix log position error when using WithXXX Add call stack print for Error, Fatal and Panic Nov 4, 2018
Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approve.

@leventeliu leventeliu merged commit 27de600 into develop Nov 4, 2018
@auxten auxten deleted the bugfix/logPosition branch November 4, 2018 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants