Update test-toolkit for Spigot/Paper split and fix example projects #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffc8683 to
d287c9a
Compare
TODO: Make modules for Spigot and Paper
Some additional cleanup
Note: I don't think these changes affect anything until they are on the `main` branch on GitHub
1f5c9e0 to
542868e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial goal was to re-enable the example projects build in the GitHub Actions workflow and make it succeed. This entailed updating
commandapi-bukkit-test-toolkitto work given the new Spigot/Paper platform split. After this PR, developers should usecommandapi-spigot-test-toolkitorcommandapi-paper-test-toolkit, which share some logic incommandapi-bukkit-test-toolkit. I also have done some miscellaneous cleanup as I was looking through stuff to make this work.This PR is based on the changes from #656
TODO:
commandapi-bukkit-test-toolkitcommandapi-spigot-test-toolkitcommandapi-paper-test-toolkit