Skip to content

Rework CommandArguments #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev/dev
Choose a base branch
from

Conversation

GliczDev
Copy link

Also makes core include jspecify and jetbrains-annotations (because jspecify doesn't cover every annotation yet). Only migrated CommandArguments to these libraries.

Not sure if I correctly included these libraries, I don't use maven.
(Paper already includes both, Spigot only jetbrains-annotations iirc)

Copy link
Member

@DerEchtePilz DerEchtePilz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally fine, but there are a few things that need to be addressed.

@GliczDev GliczDev requested a review from DerEchtePilz August 2, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants