rename `use_super_initializers` to `use_super_parameters` (#3288)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5b56d44..da82039 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,9 @@
+# 1.20.0
+
+- renamed `use_super_initializers` to `use_super_parameters`
+- fixed `unnecessary_null_aware_assignments` property-access
+ false positive
+
# 1.19.2
- new lint: `use_super_initializers`
diff --git a/example/all.yaml b/example/all.yaml
index 70e156c..24860ca 100644
--- a/example/all.yaml
+++ b/example/all.yaml
@@ -200,7 +200,7 @@
- use_rethrow_when_possible
- use_setters_to_change_properties
- use_string_buffers
- - use_super_initializers
+ - use_super_parameters
- use_test_throws_matchers
- use_to_and_as_if_applicable
- valid_regexps
diff --git a/lib/src/rules.dart b/lib/src/rules.dart
index 29ed27b..38244d2 100644
--- a/lib/src/rules.dart
+++ b/lib/src/rules.dart
@@ -204,7 +204,7 @@
import 'rules/use_rethrow_when_possible.dart';
import 'rules/use_setters_to_change_properties.dart';
import 'rules/use_string_buffers.dart';
-import 'rules/use_super_initializers.dart';
+import 'rules/use_super_parameters.dart';
import 'rules/use_test_throws_matchers.dart';
import 'rules/use_to_and_as_if_applicable.dart';
import 'rules/valid_regexps.dart';
@@ -416,7 +416,7 @@
..register(UseRawStrings())
..register(UseSettersToChangeAProperty())
..register(UseStringBuffers())
- ..register(UseSuperInitializers())
+ ..register(UseSuperParameters())
..register(UseTestThrowsMatchers())
..register(UseToAndAsIfApplicable())
..register(ValidRegExps())
diff --git a/lib/src/rules/use_super_initializers.dart b/lib/src/rules/use_super_parameters.dart
similarity index 94%
rename from lib/src/rules/use_super_initializers.dart
rename to lib/src/rules/use_super_parameters.dart
index 74753a5..5a250fb 100644
--- a/lib/src/rules/use_super_initializers.dart
+++ b/lib/src/rules/use_super_parameters.dart
@@ -42,15 +42,15 @@
```
''';
-class UseSuperInitializers extends LintRule {
+class UseSuperParameters extends LintRule {
static const LintCode singleParam =
- LintCode('use_super_initializers', "Convert '{0}' to a super parameter.");
+ LintCode('use_super_parameters', "Convert '{0}' to a super parameter.");
static const LintCode multipleParams =
- LintCode('use_super_initializers', 'Convert {0} to super parameters.');
+ LintCode('use_super_parameters', 'Convert {0} to super parameters.');
- UseSuperInitializers()
+ UseSuperParameters()
: super(
- name: 'use_super_initializers',
+ name: 'use_super_parameters',
description: _desc,
details: _details,
maturity: Maturity.experimental,
@@ -230,10 +230,10 @@
if (identifiers.length > 1) {
var msg = identifiers.quotedAndCommaSeparatedWithAnd;
rule.reportLint(target,
- errorCode: UseSuperInitializers.multipleParams, arguments: [msg]);
+ errorCode: UseSuperParameters.multipleParams, arguments: [msg]);
} else {
rule.reportLint(target,
- errorCode: UseSuperInitializers.singleParam,
+ errorCode: UseSuperParameters.singleParam,
arguments: [identifiers.first]);
}
}
diff --git a/lib/src/version.dart b/lib/src/version.dart
index 6ad379d..5eabb59 100644
--- a/lib/src/version.dart
+++ b/lib/src/version.dart
@@ -3,4 +3,4 @@
// BSD-style license that can be found in the LICENSE file.
/// Package version. Synchronized w/ pubspec.yaml.
-const String version = '1.19.2';
+const String version = '1.20.0';
diff --git a/pubspec.yaml b/pubspec.yaml
index 851366f..73662b3 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -1,5 +1,5 @@
name: linter
-version: 1.19.2
+version: 1.20.0
description: >-
The implementation of the lint rules supported by the analyzer framework.
diff --git a/test/rules/all.dart b/test/rules/all.dart
index 45fdbe4..8aa8842 100644
--- a/test/rules/all.dart
+++ b/test/rules/all.dart
@@ -70,7 +70,7 @@
import 'use_enums_test.dart' as use_enums;
import 'use_is_even_rather_than_modulo_test.dart'
as use_is_even_rather_than_modulo;
-import 'use_super_initializers_test.dart' as use_super_initializers;
+import 'use_super_parameters_test.dart' as use_super_parameters;
import 'void_checks_test.dart' as void_checks;
void main() {
@@ -120,6 +120,6 @@
unnecessary_overrides.main();
use_enums.main();
use_is_even_rather_than_modulo.main();
- use_super_initializers.main();
+ use_super_parameters.main();
void_checks.main();
}
diff --git a/test/rules/use_super_initializers_test.dart b/test/rules/use_super_parameters_test.dart
similarity index 89%
rename from test/rules/use_super_initializers_test.dart
rename to test/rules/use_super_parameters_test.dart
index 1a3109f..d6684e2 100644
--- a/test/rules/use_super_initializers_test.dart
+++ b/test/rules/use_super_parameters_test.dart
@@ -8,19 +8,19 @@
main() {
defineReflectiveSuite(() {
- defineReflectiveTests(UseSuperInitializersTest);
+ defineReflectiveTests(UseSuperParametersTest);
});
}
@reflectiveTest
-class UseSuperInitializersTest extends LintRuleTest {
+class UseSuperParametersTest extends LintRuleTest {
@override
List<String> get experiments => [
EnableString.super_parameters,
];
@override
- String get lintRule => 'use_super_initializers';
+ String get lintRule => 'use_super_parameters';
test_named() async {
await assertDiagnostics(r'''
@@ -31,7 +31,7 @@
const B({int? x, int? y}) : super(x: x, y: y);
}
''', [
- lint('use_super_initializers', 69, 1),
+ lint('use_super_parameters', 69, 1),
]);
}
@@ -182,7 +182,7 @@
B(int x, {int? foo}) : super(x, foo: 0);
}
''', [
- lint('use_super_initializers', 59, 1),
+ lint('use_super_parameters', 59, 1),
]);
}
@@ -195,7 +195,7 @@
B(int x) : super(x);
}
''', [
- lint('use_super_initializers', 56, 1),
+ lint('use_super_parameters', 56, 1),
]);
}
@@ -208,7 +208,7 @@
B([int x = 0]) : super(x);
}
''', [
- lint('use_super_initializers', 46, 1),
+ lint('use_super_parameters', 46, 1),
]);
}
@@ -223,7 +223,7 @@
C(int foo, int bar) : super(foo, bar);
}
''', [
- lint('use_super_initializers', 93, 1),
+ lint('use_super_parameters', 93, 1),
]);
}
@@ -236,7 +236,7 @@
B(int x, int y) : super(x, y: y);
}
''', [
- lint('use_super_initializers', 56, 1),
+ lint('use_super_parameters', 56, 1),
]);
}
@@ -251,7 +251,7 @@
C(int baz, int foo, int bar) : super(foo, bar);
}
''', [
- lint('use_super_initializers', 93, 1),
+ lint('use_super_parameters', 93, 1),
]);
}
@@ -264,7 +264,7 @@
B(int x, {int? y}) : super(x, y: y);
}
''', [
- lint('use_super_initializers', 56, 1),
+ lint('use_super_parameters', 56, 1),
]);
}
}