-
-
Notifications
You must be signed in to change notification settings - Fork 178
Closed
Description
MipmapGenerator
depends on a compiled compute shader under content_dir ++ "shaders/generate_mipmaps.cs.cso"
That file is build time compiled in each sample:
zig-gamedev/samples/simple_raytracer/build.zig
Lines 88 to 97 in 828a078
makeDxcCmd( | |
b, | |
dxc_step, | |
"../common/src/hlsl/common.hlsl", | |
"csGenerateMipmaps", | |
"generate_mipmaps.cs.cso", | |
"cs", | |
"PSO__GENERATE_MIPMAPS", | |
); | |
makeDxcCmd( |
Second, content_dir
is a sample concept that libs should not have.
Related to this I find it awkward a lib would directly load from the filesystem instead of be given the bytes. By allowing the caller to pass in the bytes, it can decide to either:
- load it from the filesystem
- compile it at runtime
- already have loaded via
@embedFile
Metadata
Metadata
Assignees
Labels
No labels