Skip to content

zd3d12 lib MipmapGenerator depends on sample #556

@Pyrolistical

Description

@Pyrolistical

MipmapGenerator depends on a compiled compute shader under content_dir ++ "shaders/generate_mipmaps.cs.cso"

That file is build time compiled in each sample:

makeDxcCmd(
b,
dxc_step,
"../common/src/hlsl/common.hlsl",
"csGenerateMipmaps",
"generate_mipmaps.cs.cso",
"cs",
"PSO__GENERATE_MIPMAPS",
);
makeDxcCmd(

Second, content_dir is a sample concept that libs should not have.

Related to this I find it awkward a lib would directly load from the filesystem instead of be given the bytes. By allowing the caller to pass in the bytes, it can decide to either:

  1. load it from the filesystem
  2. compile it at runtime
  3. already have loaded via @embedFile

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions